Page MenuHomePhabricator

Use CustomField, not AuxiliaryField, to power RevisionView
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:27 PM.
Tags
None
Referenced Files
F15721538: D8361.diff
Thu, May 29, 8:17 AM
Unknown Object (File)
Tue, May 20, 3:41 PM
Unknown Object (File)
Mon, May 19, 7:01 PM
Unknown Object (File)
Mon, May 19, 2:18 AM
Unknown Object (File)
Fri, May 9, 11:09 PM
Unknown Object (File)
Fri, May 9, 8:42 PM
Unknown Object (File)
Thu, May 8, 11:49 AM
Unknown Object (File)
Tue, May 6, 5:21 AM
Subscribers

Details

Summary

Ref T2222. This will probably have some rough edges for a bit (e.g., weird cases I didn't remember or think of), but there's no change to the underlying data and we can easily revert if things get too messy.

Test Plan

Looked at a variety of revisions and saw sensible output.

Diff Detail

Repository
rP Phabricator
Branch
dfield1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 6:30 PM
  • Fix a spelling issue.
  • Remove an unused property.
conf/default.conf.php
790

As far as I know, only Facebook uses this. The modern event-based version has been available for something like 18 months.