Page MenuHomePhabricator

Don't consider integer CustomFields as changed when the number doesn't change
ClosedPublic

Authored by epriestley on Feb 21 2014, 4:52 PM.
Tags
None
Referenced Files
F14123987: D8292.diff
Sat, Nov 30, 1:02 AM
Unknown Object (File)
Fri, Nov 29, 1:54 AM
Unknown Object (File)
Fri, Nov 29, 1:54 AM
Unknown Object (File)
Fri, Nov 29, 1:54 AM
Unknown Object (File)
Wed, Nov 27, 6:50 AM
Unknown Object (File)
Tue, Nov 26, 5:21 PM
Unknown Object (File)
Sat, Nov 23, 3:21 AM
Unknown Object (File)
Mon, Nov 18, 10:21 PM
Subscribers

Details

Summary

Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan

{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped