Page MenuHomePhabricator

Don't consider integer CustomFields as changed when the number doesn't change
ClosedPublic

Authored by epriestley on Feb 21 2014, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 23, 1:33 PM
Unknown Object (File)
Mon, Sep 23, 1:33 PM
Unknown Object (File)
Mon, Sep 23, 1:33 PM
Unknown Object (File)
Mon, Sep 23, 1:27 PM
Unknown Object (File)
Sun, Sep 22, 2:38 AM
Unknown Object (File)
Wed, Sep 4, 10:49 AM
Unknown Object (File)
Aug 24 2024, 5:29 PM
Unknown Object (File)
Aug 22 2024, 9:01 AM
Subscribers

Details

Summary

Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan

{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Diff Detail

Repository
rP Phabricator
Branch
intfield
Lint
Lint Passed
Unit
Tests Passed