Page MenuHomePhabricator

Don't consider integer CustomFields as changed when the number doesn't change
ClosedPublic

Authored by epriestley on Feb 21 2014, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 3:21 AM
Unknown Object (File)
Mon, Nov 18, 10:21 PM
Unknown Object (File)
Mon, Nov 11, 4:05 AM
Unknown Object (File)
Fri, Nov 8, 10:41 PM
Unknown Object (File)
Sun, Nov 3, 5:48 AM
Unknown Object (File)
Mon, Oct 28, 3:45 PM
Unknown Object (File)
Oct 17 2024, 5:42 AM
Unknown Object (File)
Oct 14 2024, 10:15 AM
Subscribers

Details

Summary

Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan

{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Diff Detail

Repository
rP Phabricator
Branch
intfield
Lint
Lint Passed
Unit
Tests Passed