Page MenuHomePhabricator

Don't consider integer CustomFields as changed when the number doesn't change
ClosedPublic

Authored by epriestley on Feb 21 2014, 4:52 PM.
Tags
None
Referenced Files
F15549822: D8292.diff
Sun, Apr 27, 7:53 AM
F15481234: D8292.id19720.diff
Tue, Apr 8, 7:14 PM
F15445703: D8292.diff
Mar 27 2025, 3:34 PM
F15436793: D8292.id19720.diff
Mar 25 2025, 4:34 PM
F15407026: D8292.id19719.diff
Mar 18 2025, 3:14 PM
F15379028: D8292.diff
Mar 13 2025, 6:16 PM
F15374264: D8292.id19720.diff
Mar 12 2025, 6:00 PM
F15347917: D8292.diff
Mar 10 2025, 2:09 PM
Subscribers

Details

Summary

Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan

{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Diff Detail

Repository
rP Phabricator
Branch
intfield
Lint
Lint Passed
Unit
Tests Passed