Page MenuHomePhabricator

Don't consider integer CustomFields as changed when the number doesn't change
ClosedPublic

Authored by epriestley on Feb 21 2014, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 17, 1:29 PM
Unknown Object (File)
Mon, Feb 17, 1:29 PM
Unknown Object (File)
Mon, Feb 17, 1:29 PM
Unknown Object (File)
Sat, Feb 15, 11:28 AM
Unknown Object (File)
Tue, Feb 11, 9:30 PM
Unknown Object (File)
Sun, Feb 9, 11:35 AM
Unknown Object (File)
Sun, Feb 9, 11:35 AM
Unknown Object (File)
Sun, Feb 9, 11:35 AM
Subscribers

Details

Summary

Fixes T4466. We do an excessively strict effect check now, which means that these fields changing from (string) "16" to (int) 16 generates a transaction. Instead, compare integer values if the field has data in it.

Test Plan

{F116261}

(Also made updates without changing the number, which did not appear in the transaction log anymore.)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped