Page MenuHomePhabricator

Implement update and history controllers in Phragment
ClosedPublic

Authored by hach-que on Dec 6 2013, 6:07 AM.
Tags
None
Referenced Files
F15457036: D7727.id17473.diff
Sun, Mar 30, 1:54 PM
F15452837: D7727.id.diff
Sat, Mar 29, 7:38 AM
F15452661: D7727.id17449.diff
Sat, Mar 29, 6:32 AM
F15449538: D7727.diff
Fri, Mar 28, 10:50 AM
F15434400: D7727.id.diff
Tue, Mar 25, 3:24 AM
F15389135: D7727.id17473.diff
Sat, Mar 15, 4:55 AM
F15387882: D7727.id17471.diff
Sat, Mar 15, 3:03 AM
F15385311: D7727.id17461.diff
Fri, Mar 14, 10:13 PM

Details

Summary

Depends on D7726. This adds a history controller (for viewing a list of patches associated with a fragment) and an update controller, for creating a new patch of a fragment.

Test Plan

Updated and viewed history of fragments.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Unknown Object (????).Dec 6 2013, 11:21 PM

Updated for latest version of D7726

epriestley added inline comments.
src/applications/phragment/controller/PhragmentUpdateController.php
41–48

Might be worth a :

$fragment->openTransaction();
  // ... save(); save();
$fragment->saveTransaction();

...until we get ApplicationTransactions in, just to make sure the database stays consistent.

43

Bad copy/paste on the comment?

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:53 AM

Changes requested in code review

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:55 AM

Fix bad get PHID call