Page MenuHomePhabricator

Implement update and history controllers in Phragment
ClosedPublic

Authored by hach-que on Dec 6 2013, 6:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 6:17 AM
Unknown Object (File)
Feb 9 2024, 3:05 PM
Unknown Object (File)
Feb 7 2024, 8:13 PM
Unknown Object (File)
Feb 2 2024, 1:54 AM
Unknown Object (File)
Feb 1 2024, 9:07 PM
Unknown Object (File)
Jan 24 2024, 3:52 PM
Unknown Object (File)
Jan 24 2024, 3:52 PM
Unknown Object (File)
Jan 24 2024, 3:52 PM

Details

Summary

Depends on D7726. This adds a history controller (for viewing a list of patches associated with a fragment) and an update controller, for creating a new patch of a fragment.

Test Plan

Updated and viewed history of fragments.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Unknown Object (????).Dec 6 2013, 11:21 PM

Updated for latest version of D7726

epriestley added inline comments.
src/applications/phragment/controller/PhragmentUpdateController.php
41–48

Might be worth a :

$fragment->openTransaction();
  // ... save(); save();
$fragment->saveTransaction();

...until we get ApplicationTransactions in, just to make sure the database stays consistent.

43

Bad copy/paste on the comment?

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:53 AM

Changes requested in code review

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:55 AM

Fix bad get PHID call