Page MenuHomePhabricator

Implement update and history controllers in Phragment
ClosedPublic

Authored by hach-que on Dec 6 2013, 6:07 AM.
Tags
None
Referenced Files
F12183346: D7727.id.diff
Thu, Sep 14, 12:20 PM
F12181168: D7727.id17473.diff
Tue, Sep 12, 5:50 PM
F12181167: D7727.id17472.diff
Tue, Sep 12, 5:50 PM
F12178769: D7727.diff
Mon, Sep 11, 4:39 PM
F12178074: D7727.diff
Mon, Sep 11, 6:11 AM
F12161198: D7727.diff
Wed, Sep 6, 2:25 PM
F12151674: D7727.id17461.diff
Sun, Sep 3, 7:56 AM
F12142327: D7727.diff
Aug 30 2023, 7:01 AM

Details

Summary

Depends on D7726. This adds a history controller (for viewing a list of patches associated with a fragment) and an update controller, for creating a new patch of a fragment.

Test Plan

Updated and viewed history of fragments.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Unknown Object (????).Dec 6 2013, 11:21 PM

Updated for latest version of D7726

epriestley added inline comments.
src/applications/phragment/controller/PhragmentUpdateController.php
41–48

Might be worth a :

$fragment->openTransaction();
  // ... save(); save();
$fragment->saveTransaction();

...until we get ApplicationTransactions in, just to make sure the database stays consistent.

43

Bad copy/paste on the comment?

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:53 AM

Changes requested in code review

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:55 AM

Fix bad get PHID call