Page MenuHomePhabricator

Implement update and history controllers in Phragment
ClosedPublic

Authored by hach-que on Dec 6 2013, 6:07 AM.
Tags
None
Referenced Files
F18737259: D7727.diff
Wed, Oct 1, 9:43 AM
F18696713: D7727.diff
Sat, Sep 27, 8:17 AM
F18678762: D7727.diff
Thu, Sep 25, 11:16 PM
F18672959: D7727.id17473.diff
Thu, Sep 25, 8:47 AM
F18658777: D7727.id17471.diff
Tue, Sep 23, 8:22 AM
F18620250: D7727.id17449.diff
Mon, Sep 15, 4:37 AM
F18414972: D7727.diff
Aug 30 2025, 9:13 AM
F18195449: D7727.diff
Aug 17 2025, 3:50 PM

Details

Summary

Depends on D7726. This adds a history controller (for viewing a list of patches associated with a fragment) and an update controller, for creating a new patch of a fragment.

Test Plan

Updated and viewed history of fragments.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Unknown Object (????).Dec 6 2013, 11:21 PM

Updated for latest version of D7726

epriestley added inline comments.
src/applications/phragment/controller/PhragmentUpdateController.php
41–48

Might be worth a :

$fragment->openTransaction();
  // ... save(); save();
$fragment->saveTransaction();

...until we get ApplicationTransactions in, just to make sure the database stays consistent.

43

Bad copy/paste on the comment?

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:53 AM

Changes requested in code review

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:55 AM

Fix bad get PHID call