Page MenuHomePhabricator

Implement update and history controllers in Phragment
ClosedPublic

Authored by hach-que on Dec 6 2013, 6:07 AM.
Tags
None
Referenced Files
F19303187: D7727.diff
Tue, Dec 23, 8:04 PM
F19123798: D7727.id17449.diff
Wed, Dec 10, 12:43 AM
F19122026: D7727.id17472.diff
Tue, Dec 9, 11:07 PM
F19118261: D7727.id17472.diff
Tue, Dec 9, 8:15 PM
F19114473: D7727.id17461.diff
Tue, Dec 9, 6:45 PM
F19095801: D7727.id.diff
Thu, Dec 4, 6:13 AM
F19089818: D7727.diff
Wed, Dec 3, 9:29 AM
F19069219: D7727.id17471.diff
Sun, Nov 30, 1:17 PM

Details

Summary

Depends on D7726. This adds a history controller (for viewing a list of patches associated with a fragment) and an update controller, for creating a new patch of a fragment.

Test Plan

Updated and viewed history of fragments.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Unknown Object (????).Dec 6 2013, 11:21 PM

Updated for latest version of D7726

epriestley added inline comments.
src/applications/phragment/controller/PhragmentUpdateController.php
41–48

Might be worth a :

$fragment->openTransaction();
  // ... save(); save();
$fragment->saveTransaction();

...until we get ApplicationTransactions in, just to make sure the database stays consistent.

43

Bad copy/paste on the comment?

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:53 AM

Changes requested in code review

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:55 AM

Fix bad get PHID call