Page MenuHomePhabricator

Implement update and history controllers in Phragment
ClosedPublic

Authored by hach-que on Dec 6 2013, 6:07 AM.
Tags
None
Referenced Files
F18808082: D7727.id17471.diff
Sun, Oct 19, 4:48 AM
F18808081: D7727.id17461.diff
Sun, Oct 19, 4:48 AM
F18808080: D7727.id17449.diff
Sun, Oct 19, 4:48 AM
F18783763: D7727.id17461.diff
Mon, Oct 13, 9:21 AM
F18779947: D7727.id.diff
Sat, Oct 11, 3:57 PM
F18777539: D7727.id17472.diff
Sat, Oct 11, 3:31 AM
F18773353: D7727.diff
Thu, Oct 9, 9:13 AM
F18772105: D7727.id17472.diff
Thu, Oct 9, 12:20 AM

Details

Summary

Depends on D7726. This adds a history controller (for viewing a list of patches associated with a fragment) and an update controller, for creating a new patch of a fragment.

Test Plan

Updated and viewed history of fragments.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Unknown Object (????).Dec 6 2013, 11:21 PM

Updated for latest version of D7726

epriestley added inline comments.
src/applications/phragment/controller/PhragmentUpdateController.php
41–48

Might be worth a :

$fragment->openTransaction();
  // ... save(); save();
$fragment->saveTransaction();

...until we get ApplicationTransactions in, just to make sure the database stays consistent.

43

Bad copy/paste on the comment?

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:53 AM

Changes requested in code review

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:55 AM

Fix bad get PHID call