Page MenuHomePhabricator

Implement update and history controllers in Phragment
ClosedPublic

Authored by hach-que on Dec 6 2013, 6:07 AM.
Tags
None
Referenced Files
F14052645: D7727.id17473.diff
Fri, Nov 15, 9:38 AM
F14052644: D7727.id17472.diff
Fri, Nov 15, 9:38 AM
F14052642: D7727.diff
Fri, Nov 15, 9:38 AM
F14037836: D7727.id17449.diff
Sun, Nov 10, 7:26 PM
F14033256: D7727.diff
Sat, Nov 9, 5:12 PM
F14000144: D7727.diff
Thu, Oct 24, 7:33 PM
F13998320: D7727.diff
Thu, Oct 24, 8:51 AM
F13990923: D7727.id17449.diff
Tue, Oct 22, 7:21 AM

Details

Summary

Depends on D7726. This adds a history controller (for viewing a list of patches associated with a fragment) and an update controller, for creating a new patch of a fragment.

Test Plan

Updated and viewed history of fragments.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Unknown Object (????).Dec 6 2013, 11:21 PM

Updated for latest version of D7726

epriestley added inline comments.
src/applications/phragment/controller/PhragmentUpdateController.php
41–48

Might be worth a :

$fragment->openTransaction();
  // ... save(); save();
$fragment->saveTransaction();

...until we get ApplicationTransactions in, just to make sure the database stays consistent.

43

Bad copy/paste on the comment?

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:53 AM

Changes requested in code review

hach-que updated this revision to Unknown Object (????).Dec 7 2013, 1:55 AM

Fix bad get PHID call