Page MenuHomePhabricator

Add `urisprintf()` for encoded printing of URIs
ClosedPublic

Authored by epriestley on Nov 9 2013, 2:31 AM.
Tags
None
Referenced Files
F15414111: D7538.diff
Wed, Mar 19, 11:13 PM
F15411511: D7538.id17015.diff
Wed, Mar 19, 9:22 AM
F15409535: D7538.id17014.diff
Wed, Mar 19, 4:40 AM
F15399599: D7538.diff
Mon, Mar 17, 5:43 AM
F15384451: D7538.id17015.diff
Fri, Mar 14, 7:56 PM
F15372960: D7538.id17014.diff
Wed, Mar 12, 1:54 PM
F15309406: D7538.id17015.diff
Thu, Mar 6, 7:18 AM
Unknown Object (File)
Mon, Mar 3, 12:03 PM
Subscribers

Details

Summary

Ref T1049. This is primarily to enable us to do a reasonable job of variable replacement in "Request URI" Harbormaster build steps. For example, the user will enter:

http://jenkins.mycompany.com/?diff=${buildable.name}

...which we'll transform to:

http://jenkins.mycompany.com/?diff=%s

...and then build correctly.

Test Plan

Unit tests.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 9 2013, 2:40 AM
  • Add a v version too, so the implementation can mirror the RemoteCommand one more closely.