Page MenuHomePhabricator

Add `urisprintf()` for encoded printing of URIs
ClosedPublic

Authored by epriestley on Nov 9 2013, 2:31 AM.
Tags
None
Referenced Files
F13242172: D7538.diff
Thu, May 23, 2:00 AM
F13220659: D7538.diff
Sun, May 19, 1:51 AM
F13219062: D7538.id17011.diff
Sat, May 18, 2:56 PM
F13208275: D7538.id17014.diff
Thu, May 16, 12:39 PM
F13202672: D7538.diff
Tue, May 14, 10:59 PM
F13185661: D7538.diff
Sat, May 11, 3:07 AM
F13183450: D7538.id17015.diff
Fri, May 10, 9:09 AM
Unknown Object (File)
Tue, May 7, 6:05 PM
Subscribers

Details

Summary

Ref T1049. This is primarily to enable us to do a reasonable job of variable replacement in "Request URI" Harbormaster build steps. For example, the user will enter:

http://jenkins.mycompany.com/?diff=${buildable.name}

...which we'll transform to:

http://jenkins.mycompany.com/?diff=%s

...and then build correctly.

Test Plan

Unit tests.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 9 2013, 2:40 AM
  • Add a v version too, so the implementation can mirror the RemoteCommand one more closely.