Page MenuHomePhabricator

Add `urisprintf()` for encoded printing of URIs
ClosedPublic

Authored by epriestley on Nov 9 2013, 2:31 AM.
Tags
None
Referenced Files
F14078202: D7538.diff
Fri, Nov 22, 2:43 AM
Unknown Object (File)
Tue, Nov 19, 6:26 PM
Unknown Object (File)
Tue, Nov 19, 6:26 PM
Unknown Object (File)
Tue, Nov 19, 6:26 PM
Unknown Object (File)
Tue, Nov 19, 6:26 PM
Unknown Object (File)
Tue, Nov 19, 6:07 PM
Unknown Object (File)
Sun, Nov 17, 7:15 PM
Unknown Object (File)
Thu, Nov 14, 12:09 AM
Subscribers

Details

Summary

Ref T1049. This is primarily to enable us to do a reasonable job of variable replacement in "Request URI" Harbormaster build steps. For example, the user will enter:

http://jenkins.mycompany.com/?diff=${buildable.name}

...which we'll transform to:

http://jenkins.mycompany.com/?diff=%s

...and then build correctly.

Test Plan

Unit tests.

Diff Detail

Branch
urisprintf
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 9 2013, 2:40 AM
  • Add a v version too, so the implementation can mirror the RemoteCommand one more closely.