Page MenuHomePhabricator
Differential D7538

Add `urisprintf()` for encoded printing of URIs
ClosedPublic
Actions

Authored by epriestley on Nov 9 2013, 2:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 10, 12:32 AM
Unknown Object (File)
Thu, May 8, 3:37 AM
Unknown Object (File)
Wed, May 7, 2:07 PM
Unknown Object (File)
Tue, Apr 29, 9:19 PM
Unknown Object (File)
Tue, Apr 29, 8:05 PM
Unknown Object (File)
Sun, Apr 27, 1:14 AM
Unknown Object (File)
Fri, Apr 25, 4:28 PM
Unknown Object (File)
Thu, Apr 24, 11:36 PM
View All Files
Subscribers
aran
zeeg

Details

Reviewers
hach-que
btrahan
Maniphest Tasks
T1049: Implement Harbormaster
Commits
rPHU1ffb66347246: Add `urisprintf()` for encoded printing of URIs
Summary

Ref T1049. This is primarily to enable us to do a reasonable job of variable replacement in "Request URI" Harbormaster build steps. For example, the user will enter:

http://jenkins.mycompany.com/?diff=${buildable.name}

...which we'll transform to:

http://jenkins.mycompany.com/?diff=%s

...and then build correctly.

Test Plan

Unit tests.

Diff Detail

Branch
urisprintf
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

hach-que accepted this revision.Nov 9 2013, 2:35 AM

Seems reasonable.

epriestley updated this revision to Unknown Object (????).Nov 9 2013, 2:40 AM
  • Add a v version too, so the implementation can mirror the RemoteCommand one more closely.
epriestley closed this revision.Nov 9 2013, 2:40 AM

Closed by commit rPHU1ffb66347246 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
4 lines
xsprintf/
__tests__/
18 lines
47 lines

Diff 17011

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/xsprintf/__tests__/PhutilurisprintfTestCase.php

Loading...
View Options

src/xsprintf/urisprintf.php

Loading...
Phabricator · Built by Phacility