Page MenuHomePhabricator

Use extended policies in Differential diffs
ClosedPublic

Authored by epriestley on Jan 1 2017, 4:42 PM.
Tags
None
Referenced Files
F18993066: D17123.diff
Wed, Nov 19, 5:28 AM
F18875701: D17123.id41180.diff
Wed, Nov 5, 6:50 PM
F18854290: D17123.id41180.diff
Fri, Oct 31, 11:05 PM
F18833660: D17123.diff
Sun, Oct 26, 5:06 AM
F18803184: D17123.id.diff
Oct 17 2025, 10:01 PM
F18783289: D17123.diff
Oct 13 2025, 5:47 AM
F18766325: D17123.id41180.diff
Oct 7 2025, 4:08 PM
F18756199: D17123.id41186.diff
Oct 5 2025, 9:59 AM
Subscribers
None

Details

Summary

Fixes T9648. Diffs currently use return $this->getRevision()->getViewPolicy(); to inherit their revision's view policy.

After the introduction of object policies, this is wrong for policies like "Subscribers", because it means "Subscribers to this object, the diff". Since Diffs have no subscribers, this always fails.

Instead, use extended policies so that the object policy evaluates in the context of the correct object (the revision).

Test Plan
  • Create a revision.
  • Subscribe alice to it.
  • Set view policy to "Subscribers".
  • View revision as alice.
  • Before patch: nonsense fatal about missing diff because of policy error.
  • After patch: alice can see the revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable