Page MenuHomePhabricator

When rendering Remarkup codeblocks, allow calling engines to provide a style map
ClosedPublic

Authored by epriestley on May 5 2016, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 2:24 AM
Unknown Object (File)
Thu, Mar 7, 5:47 AM
Unknown Object (File)
Tue, Mar 5, 6:07 PM
Unknown Object (File)
Tue, Mar 5, 6:07 PM
Unknown Object (File)
Feb 4 2024, 11:47 AM
Unknown Object (File)
Jan 19 2024, 4:56 PM
Unknown Object (File)
Jan 16 2024, 4:43 PM
Unknown Object (File)
Jan 16 2024, 4:24 PM
Subscribers
None

Details

Summary

Ref T9790.

  • Make the HTML version of code blocks look more like the web version.
  • If the caller passes a style map, reformat the body to use style="..." instead of class="..." for HTML mail mode.
Test Plan

Faked a style map and got some inline styles (red stuff) -- see also the "style" in the inspector:

Screen Shot 2016-05-04 at 6.37.26 PM.png (970×754 px, 228 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When rendering Remarkup codeblocks, allow calling engines to provide a style map.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/markup/engine/remarkup/blockrule/PhutilRemarkupCodeBlockRule.php
147

(y)

This revision is now accepted and ready to land.May 5 2016, 1:47 AM
epriestley edited edge metadata.
  • Synchronize more styles better: counterexample, headers, margins, font sizing.
This revision was automatically updated to reflect the committed changes.