Page MenuHomePhabricator
Create Task
Maniphest T9506

arc land's help text doesn't mention default of landing in tracked branch
Closed, ResolvedPublic
Actions

Description

When I run arc help land at rARC1b4a3e0c5eb9, the information it provides about what branch it will land onto by default seems to say that it will land onto master unless otherwise specified:

Land an accepted change (currently sitting in local feature branch branch) onto master and push it to the remote.

…

--onto master
Land feature branch onto a branch other than the default ('master' in git, 'default' in hg). You can change the default by setting 'arc.land.onto.default' with arc set-config or for the entire project in .arcconfig.

If I understand the change introduced for T5690: Respect tracked branches in arc land, however, arc land will actually default to landing in the tracking branch, if there is one. If that behavior hasn't since been changed, I think it'd be nice to mention it in the help text, so that people know that they don't have to explicitly specify --onto when they want to land their change in the tracked branch.

Related Objects

Event Timeline

edibiase created this task.Oct 3 2015, 4:21 PM
edibiase updated the task description. (Show Details)
edibiase added a project: Arcanist.
edibiase added a subscriber: edibiase.
Herald added a subscriber: cspeckmim. · View Herald TranscriptOct 3 2015, 4:21 PM
edibiase renamed this task from arc land's help text for the "onto" branch is potentially confusing to arc land's help text doesn't mention default of landing in tracked branch.Oct 3 2015, 4:24 PM
avivey added a project: Documentation.Oct 3 2015, 5:59 PM
cspeckmim removed a subscriber: cspeckmim.Oct 7 2015, 1:50 AM
joshuaspence added a subscriber: joshuaspence.Oct 8 2015, 4:59 AM
vhbit added a subscriber: vhbit.Nov 9 2015, 3:32 PM
epriestley closed this task as Resolved.Nov 9 2015, 4:20 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

This was fixed as part of T9657:

A target branch is selected by examining these sources in order:

  - the --onto flag;
  - the upstream of the current branch, recursively (Git only);
  - the arc.land.onto.default configuration setting;
  - or by falling back to a standard default:
    - "master" in Git;
    - "default" in Mercurial.
epriestley mentioned this in T9657: Upgrading: arc land flow has been rewritten in git.Nov 9 2015, 4:21 PM
Phabricator · Built by Phacility