Page MenuHomePhabricator

Fix pagination of fulltext search results
ClosedPublic

Authored by epriestley on Apr 12 2017, 9:58 PM.
Tags
None
Referenced Files
F18807849: D17667.diff
Sun, Oct 19, 3:31 AM
F18783496: D17667.id.diff
Mon, Oct 13, 7:14 AM
F18754249: D17667.id.diff
Sat, Oct 4, 10:06 PM
F18741451: D17667.diff
Thu, Oct 2, 1:15 PM
F18644352: D17667.id42499.diff
Sep 19 2025, 4:58 AM
F18622798: D17667.id42490.diff
Sep 15 2025, 1:02 PM
F18508725: D17667.id.diff
Sep 5 2025, 2:59 AM
F18500840: D17667.diff
Sep 4 2025, 9:22 PM
Subscribers
None

Details

Summary

Fixes T8285. Fulltext search relies on an underlying engine which can not realistically use cursor paging. This is unusual and creates some oddness.

Tweak a few numbers -- and how offsets are handled -- to separate the filtered offset and unfiltered offset.

Test Plan
  • Set page size to 2.
  • Ran a query.
  • Paged forward and backward through results sensibly, seeing the full result set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable