Page MenuHomePhabricator

Fix pagination of fulltext search results
ClosedPublic

Authored by epriestley on Apr 12 2017, 9:58 PM.
Tags
None
Referenced Files
F18096484: D17667.id42499.diff
Fri, Aug 8, 7:16 AM
F18094543: D17667.id.diff
Thu, Aug 7, 10:11 PM
F18027837: D17667.id.diff
Sat, Aug 2, 10:39 PM
F17967165: D17667.diff
Fri, Aug 1, 12:17 PM
F17946192: D17667.diff
Thu, Jul 31, 1:46 PM
F17908479: D17667.id42490.diff
Tue, Jul 29, 1:49 PM
Unknown Object (File)
May 31 2025, 6:27 PM
Unknown Object (File)
May 31 2025, 3:55 AM
Subscribers
None

Details

Summary

Fixes T8285. Fulltext search relies on an underlying engine which can not realistically use cursor paging. This is unusual and creates some oddness.

Tweak a few numbers -- and how offsets are handled -- to separate the filtered offset and unfiltered offset.

Test Plan
  • Set page size to 2.
  • Ran a query.
  • Paged forward and backward through results sensibly, seeing the full result set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable