Page MenuHomePhabricator

Fix pagination of fulltext search results
ClosedPublic

Authored by epriestley on Apr 12 2017, 9:58 PM.
Tags
None
Referenced Files
F14751811: D17667.id.diff
Tue, Jan 21, 12:42 PM
F14745618: D17667.diff
Tue, Jan 21, 9:29 AM
Unknown Object (File)
Fri, Jan 17, 2:31 PM
Unknown Object (File)
Thu, Jan 16, 2:20 PM
Unknown Object (File)
Mon, Jan 13, 7:06 AM
Unknown Object (File)
Fri, Jan 3, 3:16 AM
Unknown Object (File)
Mon, Dec 30, 9:17 AM
Unknown Object (File)
Mon, Dec 30, 9:17 AM
Subscribers
None

Details

Summary

Fixes T8285. Fulltext search relies on an underlying engine which can not realistically use cursor paging. This is unusual and creates some oddness.

Tweak a few numbers -- and how offsets are handled -- to separate the filtered offset and unfiltered offset.

Test Plan
  • Set page size to 2.
  • Ran a query.
  • Paged forward and backward through results sensibly, seeing the full result set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable