Page MenuHomePhabricator

Fix pagination of fulltext search results
ClosedPublic

Authored by epriestley on Apr 12 2017, 9:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 1:12 PM
Unknown Object (File)
Sun, Dec 8, 9:45 AM
Unknown Object (File)
Wed, Dec 4, 7:54 AM
Unknown Object (File)
Sat, Nov 30, 12:28 PM
Unknown Object (File)
Sat, Nov 30, 3:07 AM
Unknown Object (File)
Thu, Nov 28, 1:26 AM
Unknown Object (File)
Tue, Nov 26, 7:57 AM
Unknown Object (File)
Nov 20 2024, 10:31 AM
Subscribers
None

Details

Summary

Fixes T8285. Fulltext search relies on an underlying engine which can not realistically use cursor paging. This is unusual and creates some oddness.

Tweak a few numbers -- and how offsets are handled -- to separate the filtered offset and unfiltered offset.

Test Plan
  • Set page size to 2.
  • Ran a query.
  • Paged forward and backward through results sensibly, seeing the full result set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable