Page MenuHomePhabricator

Fix pagination of fulltext search results
ClosedPublic

Authored by epriestley on Apr 12 2017, 9:58 PM.
Tags
None
Referenced Files
F22594974: D17667.id42499.diff
Mon, Sep 28, 11:02 AM
F22578086: D17667.diff
Sun, Sep 27, 2:02 PM
Unknown Object (File)
Sat, Sep 5, 1:13 AM
Unknown Object (File)
Fri, Sep 4, 3:15 PM
Unknown Object (File)
Tue, Sep 1, 1:23 PM
Unknown Object (File)
Jun 6 2026, 5:12 AM
Unknown Object (File)
Jun 6 2026, 5:12 AM
Unknown Object (File)
May 29 2026, 10:24 PM
Subscribers
None

Details

Summary

Fixes T8285. Fulltext search relies on an underlying engine which can not realistically use cursor paging. This is unusual and creates some oddness.

Tweak a few numbers -- and how offsets are handled -- to separate the filtered offset and unfiltered offset.

Test Plan
  • Set page size to 2.
  • Ran a query.
  • Paged forward and backward through results sensibly, seeing the full result set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable