Page MenuHomePhabricator

Fix pagination of fulltext search results
ClosedPublic

Authored by epriestley on Apr 12 2017, 9:58 PM.
Tags
None
Referenced Files
F15848238: D17667.id42490.diff
Sat, May 31, 3:55 AM
Unknown Object (File)
Thu, May 29, 9:15 AM
Unknown Object (File)
Wed, May 28, 1:29 PM
Unknown Object (File)
Sat, May 10, 1:47 AM
Unknown Object (File)
Apr 29 2025, 5:38 PM
Unknown Object (File)
Apr 29 2025, 8:01 AM
Unknown Object (File)
Apr 28 2025, 9:17 PM
Unknown Object (File)
Apr 26 2025, 1:04 PM
Subscribers
None

Details

Summary

Fixes T8285. Fulltext search relies on an underlying engine which can not realistically use cursor paging. This is unusual and creates some oddness.

Tweak a few numbers -- and how offsets are handled -- to separate the filtered offset and unfiltered offset.

Test Plan
  • Set page size to 2.
  • Ran a query.
  • Paged forward and backward through results sensibly, seeing the full result set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable