Page MenuHomePhabricator

Fix pagination of fulltext search results
ClosedPublic

Authored by epriestley on Apr 12 2017, 9:58 PM.
Tags
None
Referenced Files
F13060784: D17667.diff
Fri, Apr 19, 6:23 PM
Unknown Object (File)
Mon, Apr 15, 5:32 AM
Unknown Object (File)
Thu, Apr 11, 9:59 AM
Unknown Object (File)
Wed, Apr 10, 1:40 AM
Unknown Object (File)
Tue, Apr 9, 8:29 PM
Unknown Object (File)
Tue, Apr 9, 8:28 PM
Unknown Object (File)
Tue, Apr 9, 5:37 PM
Unknown Object (File)
Tue, Apr 9, 5:19 PM
Subscribers
None

Details

Summary

Fixes T8285. Fulltext search relies on an underlying engine which can not realistically use cursor paging. This is unusual and creates some oddness.

Tweak a few numbers -- and how offsets are handled -- to separate the filtered offset and unfiltered offset.

Test Plan
  • Set page size to 2.
  • Ran a query.
  • Paged forward and backward through results sensibly, seeing the full result set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable