Paths

Table of Contentst

Differential D14943

Return no results from `grep` repository queries on error
ClosedPublic
Actions

Authored by epriestley on Jan 5 2016, 2:03 PM.

Tags

None

Referenced Files

	F15182159: D14943.id.diff
	Thu, Feb 20, 12:28 AM

	Unknown Object (File)
	Wed, Feb 19, 8:07 AM

	Unknown Object (File)
	Fri, Feb 14, 4:05 AM

	Unknown Object (File)
	Wed, Feb 12, 5:36 AM

	Unknown Object (File)
	Sun, Feb 9, 12:20 AM

	Unknown Object (File)
	Sun, Feb 2, 2:37 AM

	Unknown Object (File)
	Fri, Jan 31, 5:49 PM

	Unknown Object (File)
	Tue, Jan 28, 12:50 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException")

Commits

Restricted Diffusion Commit
rPf1c298203a84: Return no results from `grep` repository queries on error

Summary

Fixes T7852. Although 1 could also indicate other kinds of problems, assume it means "no results".

Test Plan

Searched for nonsense strings in Git and Mercurial. Searched for valid strings in Git and Mercurial.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36095.Jan 5 2016, 2:03 PM

epriestley retitled this revision from to Return no results from `grep` repository queries on error.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException").

Also fix an issue with paging filename search in Git.

epriestley added inline comments.Jan 5 2016, 2:14 PM

src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php
30–31	The second issue is that pages 2+ of git results weren't returned correctly because the skipped results were discarded twice. This is one of two places where earlier pages of results were being discarded.
90–92	This is the second place where earlier pages of results were being discarded.

chad accepted this revision.Jan 5 2016, 6:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 5 2016, 6:17 PM

Closed by commit rPf1c298203a84: Return no results from `grep` repository queries on error (authored by epriestley, committed by epriestley). · Explain WhyJan 5 2016, 9:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionQueryPathsConduitAPIMethod.php

16 lines

DiffusionSearchQueryConduitAPIMethod.php

18 lines

controller/

DiffusionBrowseController.php

24 lines

Diff 36119

src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php

Loading...

src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php

Loading...

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...