Undefined variable in Conpherence
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Feb 18 2015, 9:34 PM

Description

Here's the stack trace, not sure how to repro this yet.

[Wed Feb 18 21:18:04.745148 2015] [:error] [pid 21833] [client 172.30.0.99:21300] [2015-02-18 21:18:04] EXCEPTION: (RuntimeException) Undefined variable: transaction at [<phutil>/src/error/PhutilErrorHandler.php:210]
[Wed Feb 18 21:18:04.745282 2015] [:error] [pid 21833] [client 172.30.0.99:21300]   #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/conpherence/controller/ConpherenceController.php:147]
[Wed Feb 18 21:18:04.745291 2015] [:error] [pid 21833] [client 172.30.0.99:21300]   #1 ConpherenceController::renderConpherenceTransactions(ConpherenceThread) called at [<phabricator>/src/applications/conpherence/controller/ConpherenceUpdateController.php:312]
[Wed Feb 18 21:18:04.745296 2015] [:error] [pid 21833] [client 172.30.0.99:21300]   #2 ConpherenceUpdateController::loadAndRenderUpdates(string, string, integer) called at [<phabricator>/src/applications/conpherence/controller/ConpherenceUpdateController.php:150]
[Wed Feb 18 21:18:04.745300 2015] [:error] [pid 21833] [client 172.30.0.99:21300]   #3 ConpherenceUpdateController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33]
[Wed Feb 18 21:18:04.745304 2015] [:error] [pid 21833] [client 172.30.0.99:21300]   #4 AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:196]
[Wed Feb 18 21:18:04.745308 2015] [:error] [pid 21833] [client 172.30.0.99:21300]   #5 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:121]
[Wed Feb 18 21:18:04.745312 2015] [:error] [pid 21833] [client 172.30.0.99:21300]   #6 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:19]

Revisions and Commits

rP Phabricator
	D12339	rPb14ca389401e Conpherence - improve stack re: non-update updates

Related Objects
Search...

Status	Assigned	Task
Resolved	btrahan	T7565 Ship Conpherence v2
Resolved	btrahan	T7571 Conpherence v2 Errata
Resolved	btrahan	T7318 Undefined variable in Conpherence

Event Timeline

epriestley created this task.Feb 18 2015, 9:34 PM

epriestley raised the priority of this task from to Needs Triage.

epriestley updated the task description. (Show Details)

epriestley added a project: Conpherence.

epriestley added subscribers: epriestley, chad.

epriestley added a parent task: T5364: Conpherence v2 (Original Discussion).Feb 25 2015, 11:24 PM

This happens when you do a thread update but hit 0 transactions (e.g., maybe they were all hidden), but it isn't trivially obvious what the correct thing to return is.

chad mentioned this in T7014: Annouce Persistent Chat option in Conpherence.Mar 6 2015, 11:38 PM

epriestley added a parent task: T7571: Conpherence v2 Errata.Mar 16 2015, 7:11 PM

epriestley removed a parent task: T5364: Conpherence v2 (Original Discussion).

epriestley moved this task from Backlog to v2 on the Conpherence board.Mar 16 2015, 7:22 PM

btrahan triaged this task as Normal priority.Mar 31 2015, 8:57 PM

btrahan mentioned this in D12252: Conpherence - add edit control for rooms.Apr 2 2015, 12:24 AM

btrahan mentioned this in T7761: Attempting to post empty comment breaks page.Apr 6 2015, 5:29 PM

btrahan claimed this task.Apr 8 2015, 8:28 PM

btrahan added a revision: D12339: Conpherence - improve stack re: non-update updates.Apr 9 2015, 9:59 PM

btrahan closed this task as Resolved by committing rPb14ca389401e: Conpherence - improve stack re: non-update updates.Apr 9 2015, 10:07 PM

btrahan added a commit: rPb14ca389401e: Conpherence - improve stack re: non-update updates.