Differential D15089

Give profile menus more straightforward hide/disable/delete/default interactions
ClosedPublic
Actions

Authored by epriestley on Jan 22 2016, 1:58 PM.

Tags

None

Referenced Files

	F18111316: D15089.diff
	Tue, Aug 12, 10:27 AM

	F18111179: D15089.id36430.diff
	Tue, Aug 12, 8:36 AM

	F18085691: D15089.id.diff
	Tue, Aug 5, 7:22 PM

	F17940609: D15089.diff
	Thu, Jul 31, 4:36 AM

	Unknown Object (File)
	Jun 24 2025, 6:43 PM

	Unknown Object (File)
	Jun 3 2025, 3:20 AM

	Unknown Object (File)
	May 31 2025, 9:59 AM

	Unknown Object (File)
	May 25 2025, 6:56 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10054: Define product direction for Project/Profile UIs

Commits

Restricted Diffusion Commit
rP51ed95c00b8d: Give profile menus more straightforward hide/disable/delete/default interactions

Summary

Just let users delete non-builtin items.
Let users choose a default item explicitly.
Do a better job of cleaning up items which no longer exist or belong to uninstalled applications.

This has one user-facing change: workboards are no longer the default on projects with workboards. I think this is probably OK since we're giving users a ton of new toys at the same time, but I'll write some docs at least.

Test Plan

Deleted custom items.
Disabled/enabled builtin items.
Made various things defaults.
Uninstalled Maniphest, saw Workboards tab disappear entirely.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36430.Jan 22 2016, 1:58 PM

epriestley retitled this revision from to Give profile menus more straightforward hide/disable/delete/default interactions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10054: Define product direction for Project/Profile UIs.

chad accepted this revision.Jan 22 2016, 2:58 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2016, 2:58 PM

epriestley mentioned this in T6961: Rendering of workboard columns on card objects could be marginally more efficient.Jan 22 2016, 4:04 PM

Closed by commit rP51ed95c00b8d: Give profile menus more straightforward hide/disable/delete/default interactions (authored by epriestley, committed by epriestley). · Explain WhyJan 22 2016, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

PhabricatorApplication.php

1 line

project/

controller/

PhabricatorProjectBoardViewController.php

11 lines

PhabricatorProjectViewController.php

17 lines

profilepanel/

PhabricatorProjectDetailsProfilePanel.php

5 lines

PhabricatorProjectWorkboardProfilePanel.php

5 lines

search/

engine/

PhabricatorProfilePanelEngine.php

239 lines

profilepanel/

PhabricatorProfilePanel.php

5 lines

storage/

PhabricatorProfilePanelConfiguration.php

16 lines

Diff 36439

src/applications/base/PhabricatorApplication.php

Loading...

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectViewController.php

Loading...

src/applications/project/profilepanel/PhabricatorProjectDetailsProfilePanel.php

Loading...

src/applications/project/profilepanel/PhabricatorProjectWorkboardProfilePanel.php

Loading...

src/applications/search/engine/PhabricatorProfilePanelEngine.php

Loading...

src/applications/search/profilepanel/PhabricatorProfilePanel.php

Loading...

src/applications/search/storage/PhabricatorProfilePanelConfiguration.php

Loading...