Page MenuHomePhabricator

Give profile menus more straightforward hide/disable/delete/default interactions
ClosedPublic

Authored by epriestley on Jan 22 2016, 1:58 PM.
Tags
None
Referenced Files
F14001311: D15089.id36439.diff
Fri, Oct 25, 6:18 AM
Unknown Object (File)
Oct 1 2024, 4:20 PM
Unknown Object (File)
Sep 23 2024, 11:28 PM
Unknown Object (File)
Sep 20 2024, 1:35 PM
Unknown Object (File)
Sep 11 2024, 7:09 PM
Unknown Object (File)
Sep 11 2024, 7:09 PM
Unknown Object (File)
Sep 11 2024, 7:09 PM
Unknown Object (File)
Sep 10 2024, 6:24 AM
Subscribers
None

Details

Summary

Ref T10054.

  • Just let users delete non-builtin items.
  • Let users choose a default item explicitly.
  • Do a better job of cleaning up items which no longer exist or belong to uninstalled applications.
This has one user-facing change: workboards are no longer the default on projects with workboards. I think this is probably OK since we're giving users a ton of new toys at the same time, but I'll write some docs at least.
Test Plan
  • Deleted custom items.
  • Disabled/enabled builtin items.
  • Made various things defaults.
  • Uninstalled Maniphest, saw Workboards tab disappear entirely.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give profile menus more straightforward hide/disable/delete/default interactions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 22 2016, 2:58 PM
This revision was automatically updated to reflect the committed changes.