Make Workboard icon grey if not enabled
ClosedPublic
Actions

Authored by chad on Jan 13 2015, 5:20 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP7e78a3f90609: Make Workboard icon grey if not enabled

Summary

Not sure this is obvious enough, but maybe future apps will use as well?

Test Plan

test a project with and without a workboard

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 27304.Jan 13 2015, 5:20 PM

chad retitled this revision from to Make Workboard icon grey if not enabled.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 13 2015, 5:20 PM

Doing an extra query for this isn't ideal, but there's no easy way around it and we can set some flag on the Project eventually. I think that would save a query or two elsewhere, too. I'll file a followup.

I think the grey is nice as a hint.

src/applications/project/controller/PhabricatorProjectController.php
41	This can be simplified as `$this->getViewer()` nowadays. Prefer `$viewer` (over `$user`) in modern code for consistency/clarity.

This revision is now accepted and ready to land.Jan 13 2015, 5:39 PM

epriestley mentioned this in T6961: Rendering of workboard columns on card objects could be marginally more efficient.Jan 13 2015, 5:43 PM

Closed by commit rP7e78a3f90609: Make Workboard icon grey if not enabled (authored by chad, committed by chad). · Explain WhyJan 13 2015, 5:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectController.php

13 lines

Diff 27305

View Options

src/applications/project/controller/PhabricatorProjectController.php

Make Workboard icon grey if not enabledClosedPublicActions