Page MenuHomePhabricator

Prepare Projects schema for subprojects
ClosedPublic

Authored by epriestley on Dec 19 2015, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 24, 9:50 AM
Unknown Object (File)
Mon, Jun 20, 4:27 PM
Unknown Object (File)
Sat, Jun 18, 11:32 AM
Unknown Object (File)
Fri, Jun 17, 6:59 PM
Unknown Object (File)
Thu, Jun 16, 4:14 PM
Unknown Object (File)
Thu, Jun 16, 2:40 PM
Unknown Object (File)
Mon, Jun 13, 6:11 AM
Unknown Object (File)
Thu, Jun 9, 2:44 AM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10010: Implement Subprojects
Commits
Restricted Diffusion Commit
rPaeae0e702830: Prepare Projects schema for subprojects
Summary

Ref T10010. This does some cleanups on the schema:

  • viewPolicy, editPolicy and joinPolicy were nullable, but should never be null. Set them to defaults if they're null, then make the column non-nullable.
  • Rename phrictionSlug to primarySlug and stop adding and removing trailing slashes from it.
  • Add new columns to support milestones and non-milestone subprojects.
  • Drop very old subprojectPHIDs column. This hasn't done anything in the UI for years and years, and isn't particularly realistic to migrate forward.

The new columns aren't reachable from the UI.

Test Plan
  • Applied patches.
  • Grepped for phrictionSlug.
  • Grepped for subprojectPHIDs.
  • Created tasks.
  • Edited tasks.
  • Verified existing tasks still had primary slugs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prepare Projects schema for subprojects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Make unit test use initializeNewProject() so it doesn't try to save a null value for viewPolicy.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 19 2015, 5:10 PM
This revision was automatically updated to reflect the committed changes.