Use new first-class MySQL timeout support in Phabricator
ClosedPublic
Actions

Authored by epriestley on Apr 10 2016, 11:03 AM.

Tags

None

Referenced Files

	F19000043: D15670.id.diff
	Thu, Nov 20, 10:31 PM

	F18992640: D15670.diff
	Wed, Nov 19, 3:34 AM

	F18925465: D15670.id37774.diff
	Sun, Nov 9, 6:47 PM

	F18810611: D15670.id.diff
	Oct 19 2025, 10:32 PM

	F18803737: D15670.diff
	Oct 18 2025, 3:23 AM

	F18784364: D15670.id37761.diff
	Oct 13 2025, 12:24 PM

	F18783684: D15670.id.diff
	Oct 13 2025, 8:50 AM

	F18763790: D15670.id37774.diff
	Oct 7 2025, 2:15 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T6710: Support "timeout" in vanilla MySQL connections

Commits

rPc178f29cdb8b: Use new first-class MySQL timeout support in Phabricator

Summary

Fixes T6710. After D15669, we support a proper timeout parameter, so we don't need this hack anymore.

Test Plan

See D15669: forced a MySQL connector, set a low timeout, set a bad database, saw fast failures.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37761.Apr 10 2016, 11:03 AM

epriestley retitled this revision from to Use new first-class MySQL timeout support in Phabricator.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T6710: Support "timeout" in vanilla MySQL connections.

chad accepted this revision.Apr 10 2016, 3:44 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 10 2016, 3:44 PM

Closed by commit rPc178f29cdb8b: Use new first-class MySQL timeout support in Phabricator (authored by epriestley, committed by epriestley). · Explain WhyApr 10 2016, 7:19 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 11 2016, 3:43 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

cluster/

PhabricatorDatabaseRef.php

4 lines

Diff 37774

View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Use new first-class MySQL timeout support in PhabricatorClosedPublicActions