Page MenuHomePhabricator
Differential D10721

Audit - fix erroneous mentions of tasks, etc via commit message
ClosedPublic
Actions

Authored by btrahan on Oct 16 2014, 11:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 31, 6:59 AM
Unknown Object (File)
Fri, Aug 30, 3:00 AM
Unknown Object (File)
Fri, Aug 30, 3:00 AM
Unknown Object (File)
Fri, Aug 30, 3:00 AM
Unknown Object (File)
Fri, Aug 30, 3:00 AM
Unknown Object (File)
Fri, Aug 30, 2:51 AM
Unknown Object (File)
Thu, Aug 29, 5:01 PM
Unknown Object (File)
Mon, Aug 19, 9:48 PM
View All Files
Subscribers
chad
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6331: Closing a revision via a commit generates superfluous "mention" in Task
Commits
Restricted Diffusion Commit
rPd9dd098e405b: Audit - fix erroneous mentions of tasks, etc via commit message
Summary

we don't want to mention these phids... when expanding transactions, build the unmnentionable map and make it so. slightly hairy due to how the editor framework works, but overall i think this is the right place to put these hooks. Fixes T6331.

Test Plan

made a commit with a commit message that had fixes, refs, depends on, and auditors and saw no erroneous mentions

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25735.Oct 16 2014, 11:49 PM
btrahan added a task: T6331: Closing a revision via a commit generates superfluous "mention" in Task.
btrahan retitled this revision from to Audit - fix erroneous mentions of tasks, etc via commit message.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a subscriber: chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 16 2014, 11:49 PM
Harbormaster completed remote builds in B2857: Diff 25735.Oct 16 2014, 11:50 PM
epriestley accepted this revision.Oct 16 2014, 11:57 PM
epriestley edited edge metadata.

Yeah, this is a little hairy but seems reasonable.

src/applications/audit/editor/PhabricatorAuditEditor.php
501–520

You could possibly simplify/future-proof this by using ObjectQuery (which should be able to look up "Dxxx" and "Txxx") instead of TaskQuery + RevisionQuery.

This revision is now accepted and ready to land.Oct 16 2014, 11:57 PM
btrahan updated this revision to Diff 25736.Oct 17 2014, 12:06 AM
btrahan edited edge metadata.

simplify with an object query

(re-tested by running re-parse. saw the "commit" transaction get recorded again and still no erroneous mentions.)

Harbormaster completed remote builds in B2858: Diff 25736.Oct 17 2014, 12:07 AM
Closed by commit rPd9dd098e405b: Audit - fix erroneous mentions of tasks, etc via commit message (authored by btrahan, committed by btrahan). · Explain WhyOct 17 2014, 12:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
59 lines

Diff 25737

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
Phabricator · Built by Phacility