Page MenuHomePhabricator
Differential D10712

Audit - add mail tags
ClosedPublic
Actions

Authored by btrahan on Oct 16 2014, 3:08 PM.
Tags
None
Referenced Files
F14059885: D10712.diff
Sun, Nov 17, 10:10 PM
F14050846: D10712.diff
Thu, Nov 14, 8:58 PM
F14034129: D10712.diff
Sat, Nov 9, 10:17 PM
F14020973: D10712.diff
Wed, Nov 6, 3:56 AM
F13980861: D10712.id25723.diff
Oct 19 2024, 12:57 PM
F13961288: D10712.id.diff
Oct 15 2024, 4:16 AM
Unknown Object (File)
Oct 7 2024, 11:39 PM
Unknown Object (File)
Oct 7 2024, 11:38 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Love" token, awarded by cburroughs.

Details

Reviewers
epriestley
Maniphest Tasks
T2497: Audit workflow email notifications cannot be configured
Commits
Restricted Diffusion Commit
rPac83ff706023: Audit - add mail tags
Summary

Fixes T2497. I'm not sure where we are with subscribers and custom vs normal codepath, but the mailtags implementation makes no assumptions and can handle it either way.

Test Plan

made a commit and got some sensible mail tags

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25722.Oct 16 2014, 3:08 PM
btrahan added a task: T2497: Audit workflow email notifications cannot be configured.
btrahan retitled this revision from to Audit - add mail tags.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 16 2014, 3:08 PM
Harbormaster completed remote builds in B2848: Diff 25722.Oct 16 2014, 3:09 PM
epriestley accepted this revision.Oct 16 2014, 3:10 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/audit/editor/PhabricatorAuditEditor.php
722

Tense is inconsistent -- changed -> change?

This revision is now accepted and ready to land.Oct 16 2014, 3:10 PM
cburroughs awarded a token.Oct 16 2014, 3:27 PM
Closed by commit rPac83ff706023: Audit - add mail tags (authored by btrahan, committed by btrahan). · Explain WhyOct 16 2014, 3:35 PM
This revision was automatically updated to reflect the committed changes.
btrahan mentioned this in T6331: Closing a revision via a commit generates superfluous "mention" in Task.Oct 16 2014, 3:38 PM
chad mentioned this in T6344: Changes to E-mail Preferences adversely affected Audits.Oct 18 2014, 6:30 PM
chad mentioned this in T7321: Enhancement Request: Ability to globally disable email notifications for Diffusion repository.Feb 19 2015, 3:16 AM

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
27 lines
storage/
62 lines

Diff 25723

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...
Phabricator · Built by Phacility