Page MenuHomePhabricator
Differential D11305

Tokenizers - improve algorithm around exact matches.
ClosedPublic
Actions

Authored by btrahan on Jan 9 2015, 10:43 PM.
Tags
None
Referenced Files
F19881936: D11305.diff
Thu, Mar 19, 3:31 AM
F19868549: D11305.diff
Sun, Mar 15, 3:16 AM
F19841515: D11305.diff
Wed, Mar 11, 8:15 PM
F19826935: D11305.id27163.diff
Mon, Mar 9, 3:52 AM
F19825493: D11305.id27164.diff
Sun, Mar 8, 12:02 PM
F19811826: D11305.diff
Wed, Mar 4, 2:40 AM
F19799311: D11305.id27162.diff
Fri, Feb 27, 11:21 PM
F19799037: D11305.id27164.diff
Fri, Feb 27, 10:48 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6102: Improve typeahead behavior around exact matches
Commits
Restricted Diffusion Commit
rP49ee09be3f45: Tokenizers - improve algorithm around exact matches.
Summary

Fixes T6102. Gets the from D10867 running in the tokenizer. This thing is pretty copy / pastey, but I guess that's okay?

Test Plan

looked at a project tokenizer and typed "project". since I have a million things with the word "project" in it, I was delighted to see the "project" project first in this project tokenizer.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27162.Jan 9 2015, 10:43 PM
btrahan added a task: T6102: Improve typeahead behavior around exact matches.
btrahan retitled this revision from to Tokenizers - improve algorithm around exact matches..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 9 2015, 10:43 PM
btrahan added inline comments.Jan 9 2015, 10:44 PM
webroot/rsrc/js/core/Prefab.js
105–107

whoops, will fix

btrahan updated this revision to Diff 27163.Jan 9 2015, 10:45 PM

forgot the "/g" on the quick regex I wrote in my text editor to update the iteration variables.

epriestley accepted this revision.Jan 9 2015, 10:52 PM
epriestley edited edge metadata.

yeah fix all that extra jj stuff

seems fine otherwise

This revision is now accepted and ready to land.Jan 9 2015, 10:52 PM
epriestley added a comment.Jan 9 2015, 10:53 PM

(Your update is fine, I was just looking at v1.)

Closed by commit rP49ee09be3f45: Tokenizers - improve algorithm around exact matches. (authored by btrahan, committed by btrahan). · Explain WhyJan 9 2015, 10:54 PM
This revision was automatically updated to reflect the committed changes.
aklapper mentioned this in T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.Jun 11 2015, 11:48 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
30 lines
webroot/
rsrc/
js/
core/
11 lines

Diff 27164

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/core/Prefab.js

Loading...
Phabricator · Built by Phacility