Page MenuHomePhabricator

Search Typeahead - make exact matches show up first
ClosedPublic

Authored by btrahan on Nov 17 2014, 11:11 PM.
Tags
None
Referenced Files
F13446461: D10867.diff
Sat, Jul 13, 1:59 AM
F13428337: D10867.id26091.diff
Tue, Jul 9, 9:27 PM
F13426928: D10867.id.diff
Tue, Jul 9, 1:19 PM
F13417557: D10867.diff
Sun, Jul 7, 11:31 PM
F13399933: D10867.diff
Thu, Jul 4, 10:44 AM
F13370218: D10867.id26095.diff
Thu, Jun 27, 3:54 PM
F13348737: D10867.id26095.diff
Sat, Jun 22, 11:31 PM
F13348736: D10867.id.diff
Sat, Jun 22, 11:31 PM
Subscribers

Details

Summary

Fixes T6102. Give "priority" treatment to strings that are exact matches.

Test Plan

made a bunch of projects with the word project in them including "Project". before patch, "Project" wouldn't even show up if I typed "Project" - now its the second result right after the application "Projects".

Screen_Shot_2014-11-17_at_3.13.45_PM.png (1×2 px, 820 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Search Typeahead - make exact matches show up first.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Do we need toLowerCase()? I think we might already have called it on both parts (maybe only one part?) by the time we get here.

This revision is now accepted and ready to land.Nov 17 2014, 11:28 PM

I'll do some testing to try to figure it out...

btrahan edited edge metadata.

remove toLowerCase for both parts; they must be normalized by now in the stack

tested by searching for PROJECT, project, pRoJeCt, and PROJECT EVER... got the right results each time.

This revision was automatically updated to reflect the committed changes.