A HackerOne researcher managed to find some sensitive information in stack traces in daemon logs. D9540 fixes this, but in the long term we need to move these logs out of the web UI to bin/phd log or similar.
Description
Description
Revisions and Commits
Revisions and Commits
| rP Phabricator | |||
| D10385 | rP340b40172fb9 Tweak --limit for bin/phd log | ||
| D10371 | rP06882a99cf92 Daemons - move combined log to console | ||
Related Objects
Related Objects
- Duplicates Merged Here
- T5326: Provide a mechanism to filter daemon logs
Event Timeline
Comment Actions
I merged T5326 here since I plan to move "Combined Log" to bin/phd log. Then grep lets you filter, and we could add some other flags if other things make sense.
Comment Actions
We should do this as a security thing -- although we aren't currently aware of anything sensitive in the logs, there has been sensitive stuff in the past, and it's reasonable to think there may be sensitive stuff in the future. Basically:
- bin/phd log already exists, but requires a daemon ID.
- Instead, let bin/phd log with no daemon ID behave like the combined log (emit all log messages). This will probably need a --limit flag too, like bin/mail list-outbound.
- Remove the web UI for the "Combined Log" on the Daemon console.