Page MenuHomePhabricator
Differential D10371

Daemons - move combined log to console
ClosedPublic
Actions

Authored by btrahan on Aug 27 2014, 9:42 PM.
Tags
None
Referenced Files
F14053758: D10371.diff
Fri, Nov 15, 6:58 PM
F14043201: D10371.diff
Tue, Nov 12, 8:12 AM
F14036080: D10371.id24963.diff
Sun, Nov 10, 8:29 AM
F14027111: D10371.diff
Fri, Nov 8, 5:10 AM
F14010401: D10371.id24961.diff
Thu, Oct 31, 7:25 AM
F14002952: D10371.id24961.diff
Sat, Oct 26, 12:15 AM
F13992098: D10371.id24963.diff
Tue, Oct 22, 2:19 PM
F13988045: D10371.diff
Mon, Oct 21, 12:49 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5405: Move daemon logs from the web UI to console-only
Commits
Restricted Diffusion Commit
rP06882a99cf92: Daemons - move combined log to console
Summary

Fixes T5405.

Test Plan

ran a few commands (log, log --id X --id Y, log --id BADX, log --id BADX --id BADY) and verified good output

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24961.Aug 27 2014, 9:42 PM
btrahan added a task: T5405: Move daemon logs from the web UI to console-only.
btrahan retitled this revision from to Daemons - move combined log to console.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 27 2014, 9:42 PM
btrahan edited the test plan for this revision. (Show Details)Aug 27 2014, 9:42 PM
Harbormaster completed remote builds in B2371: Diff 24961.Aug 27 2014, 9:42 PM
epriestley accepted this revision.Aug 27 2014, 9:45 PM
epriestley edited edge metadata.

Cool, looks reasonable to me.

This revision is now accepted and ready to land.Aug 27 2014, 9:45 PM
btrahan closed this revision.Aug 27 2014, 9:50 PM
btrahan updated this revision to Diff 24963.

Closed by commit rP06882a99cf92 (authored by @btrahan).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
daemon/
application/
1 line
controller/
1 line
management/
62 lines
infrastructure/
internationalization/
translation/
4 lines

Diff 24963

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/daemon/application/PhabricatorDaemonsApplication.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorDaemonCombinedLogController.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorDaemonController.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementLogWorkflow.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...
Phabricator · Built by Phacility