Page MenuHomePhabricator

Disable the edit/quote menu for non-standard comments
ClosedPublic

Authored by epriestley on May 18 2014, 12:38 PM.
Tags
None
Referenced Files
F14060729: D9180.diff
Mon, Nov 18, 3:12 AM
F14046646: D9180.diff
Wed, Nov 13, 10:38 PM
F14037607: D9180.id21803.diff
Sun, Nov 10, 5:32 PM
F14034497: D9180.diff
Sun, Nov 10, 12:39 AM
F14021237: D9180.diff
Wed, Nov 6, 6:46 AM
F13973974: D9180.id21855.diff
Oct 18 2024, 3:28 AM
F13973722: D9180.id.diff
Oct 18 2024, 2:15 AM
F13968341: D9180.id.diff
Oct 16 2024, 8:18 PM

Details

Summary

Fixes T4930. We currently show the edit/quote menu if a transaction group has inline comments, but this doesn't make sense and doesn't work properly. Only show this menu if the group has a normal comment.

Test Plan

Viewed these groups:

  • Normal comment (edits fine).
  • Just inlines (no more edit menu).
  • Inline + comment (edits fine, affects the normal comment properly).

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Disable the edit/quote menu for non-standard comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:53 PM
epriestley updated this revision to Diff 21855.

Closed by commit rP703e0b396888 (authored by @epriestley).