Page MenuHomePhabricator

Disable the edit/quote menu for non-standard comments
ClosedPublic

Authored by epriestley on May 18 2014, 12:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 7:08 AM
Unknown Object (File)
Feb 12 2024, 4:24 PM
Unknown Object (File)
Feb 10 2024, 3:07 AM
Unknown Object (File)
Jan 27 2024, 1:27 AM
Unknown Object (File)
Jan 19 2024, 3:41 PM
Unknown Object (File)
Dec 23 2023, 9:37 AM
Unknown Object (File)
Dec 19 2023, 10:32 PM
Unknown Object (File)
Dec 17 2023, 11:14 AM

Details

Summary

Fixes T4930. We currently show the edit/quote menu if a transaction group has inline comments, but this doesn't make sense and doesn't work properly. Only show this menu if the group has a normal comment.

Test Plan

Viewed these groups:

  • Normal comment (edits fine).
  • Just inlines (no more edit menu).
  • Inline + comment (edits fine, affects the normal comment properly).

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Disable the edit/quote menu for non-standard comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:53 PM
epriestley updated this revision to Diff 21855.

Closed by commit rP703e0b396888 (authored by @epriestley).