Page MenuHomePhabricator

Disable the edit/quote menu for non-standard comments
ClosedPublic

Authored by epriestley on May 18 2014, 12:38 PM.
Tags
None
Referenced Files
F19680812: D9180.id21803.diff
Sun, Feb 8, 8:30 PM
F19632046: D9180.id21855.diff
Thu, Feb 5, 4:42 AM
F19575709: D9180.diff
Sun, Feb 1, 7:23 AM
F19531100: D9180.id21855.diff
Tue, Jan 20, 2:32 AM
F19527538: D9180.id21855.diff
Mon, Jan 19, 2:30 AM
F19389264: D9180.diff
Dec 27 2025, 5:18 AM
F19100412: D9180.diff
Dec 4 2025, 11:09 PM
F18922580: D9180.id21855.diff
Nov 9 2025, 3:37 PM

Details

Summary

Fixes T4930. We currently show the edit/quote menu if a transaction group has inline comments, but this doesn't make sense and doesn't work properly. Only show this menu if the group has a normal comment.

Test Plan

Viewed these groups:

  • Normal comment (edits fine).
  • Just inlines (no more edit menu).
  • Inline + comment (edits fine, affects the normal comment properly).

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Disable the edit/quote menu for non-standard comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:53 PM
epriestley updated this revision to Diff 21855.

Closed by commit rP703e0b396888 (authored by @epriestley).