Page MenuHomePhabricator

Removing comments in Differential does not remove inline comments
Closed, DuplicatePublic

Description

Using the new delete / remove comment feature in Differential doesn't cause associated inline comments to be removed that are associated with the original comment.

Event Timeline

hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Differential.
hach-que added subscribers: hach-que, epriestley.

This is intentional; I'm going to merge it into the similar T4930. Basically:

  • Right now, you aren't supposed to be able to edit or remove inline comments at all. This will be supported in the future, but right now there's still a wrapper/abstraction layer that makes it not work. This will be exposed on the comment itself, not at top level.
  • The UI sometimes makes it look like you can affect inlines, incorrectly. T4930 will resolve that part.