Page MenuHomePhabricator
Create Task
Maniphest T4770

User reports `arc land` no longer causing revisions to close
Closed, InvalidPublic
Actions

Description

Hi,

We just updated phabricator and noticed that “arc land” does not close revision anymore.

We are using the following command for merging:

arc land --merge --onto master --revision D743

But the review remains in “accepted” status.

I also noticed in your last ChangeLog:

  • arc close-revision now uses more modern repository detection.
  • arc amend will no longer close revisions as a side effect of amending (this behavior was rare and confusing).

Do you think there could be an impact into "arc land" command?

Event Timeline

epriestley created this task.Apr 8 2014, 12:28 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added projects: Arcanist, Differential.
epriestley added subscribers: epriestley, benjamin.cohen-solal, btrahan.
  • The arc amend change should not have impacted this.
  • Another user has supported a similar issue (see T4767) but we aren't seeing it ourselves. I'm planning to add some more diagnostics to fix that issue, which might also help us fix this issue. If not, we can look at this separately.
epriestley closed this task as Invalid.Apr 12 2014, 12:16 AM
epriestley claimed this task.

From a followup, it sounds like this was just a configuration issue.

nealsun added a subscriber: nealsun.Jul 26 2016, 3:21 AM

so how to set the configuration to auto close revision after arc land?

Herald added a subscriber: eadler. · View Herald TranscriptJul 26 2016, 3:21 AM
chad added a subscriber: chad.Jul 26 2016, 7:01 AM

@nealsun https://secure.phabricator.com/book/phabricator/article/diffusion_autoclose/

nealsun added a comment.Jul 26 2016, 8:15 AM
In T4770#187220, @chad wrote:

@nealsun https://secure.phabricator.com/book/phabricator/article/diffusion_autoclose/

@chad Thanks！ Auto close now works. But I already set it in diffusion, and another error T9665 make it failed.
Run the following command to finish the Importinting.
./phabricator/bin/repository update R2

Phabricator · Built by Phacility