Page MenuHomePhabricator
Differential D13289

Call didRejectResult() in DiffusionCommitQuery properly
ClosedPublic
Actions

Authored by epriestley on Jun 14 2015, 10:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 9:51 AM
Unknown Object (File)
Tue, Apr 9, 12:04 PM
Unknown Object (File)
Thu, Apr 4, 7:59 PM
Unknown Object (File)
Thu, Apr 4, 3:51 PM
Unknown Object (File)
Thu, Apr 4, 1:07 AM
Unknown Object (File)
Thu, Apr 4, 12:14 AM
Unknown Object (File)
Fri, Mar 29, 10:13 AM
Unknown Object (File)
Wed, Mar 27, 1:53 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T4345: Some objects are not properly rejected from willFilterPage() by calling didRejectResult(), producing "Unknown Object (Object Type)"
Commits
Restricted Diffusion Commit
rP2fbc65e39649: Call didRejectResult() in DiffusionCommitQuery properly
Summary

Ref T4345. This error is per object-type in the query implementations, not a mail/permissions issue.

Without didRejectResult(), we can't distinguish between "restricted" and "unknown" for objects filtered by willFilterPage().

  • Call didRejectResult() on commits.
  • Make didRejectResult() handle both existing policy exceptions and filtering.
  • Recover from partial objects (like commits) which are missing attached data required to figure out policies.
Test Plan

Saw "Restricted Diffusion Commit" instead of "Unknown Object (Diffusion Commit)" when viewing nonvisible commit handle in Maniphest.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32130.Jun 14 2015, 10:28 PM
epriestley retitled this revision from to Call didRejectResult() in DiffusionCommitQuery properly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
epriestley added a task: T4345: Some objects are not properly rejected from willFilterPage() by calling didRejectResult(), producing "Unknown Object (Object Type)".
Herald added a subscriber: epriestley. · View Herald TranscriptJun 14 2015, 10:28 PM
joshuaspence accepted this revision.Jun 14 2015, 10:31 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2015, 10:31 PM
Closed by commit rP2fbc65e39649: Call didRejectResult() in DiffusionCommitQuery properly (authored by epriestley, committed by epriestley). · Explain WhyJun 14 2015, 10:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
query/
1 line
infrastructure/
query/
policy/
18 lines

Diff 32132

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility