Page MenuHomePhabricator

When taking multiple actions in Transactions, feed stories are inconsistenly publised.
Closed, ResolvedPublic

Description

See https://secure.phabricator.com/T4058, when I commented I also added myself in to the subscribers. This created 2 transactions but only 1 feed story. I would expect 2 feed stories in this case, or if 1, just the comment.

Revisions and Commits

Restricted Differential Revision

Event Timeline

chad raised the priority of this task from to Low.
chad updated the task description. (Show Details)
chad added projects: Feed, Transactions.
chad added subscribers: chad, epriestley, btrahan.

The way this is supposed to work now is:

  • All the transactions generate a single feed story.
  • The story features the "most important" action.

So I'd expect one feed story, but that it should feature the comment, not the CC. This is probably because Maniphest uses custom subscriptions, so the "subscription" part doesn't have the correct (lower) priority, or something like that.

(The less-quick fix is to get Maniphest on proper Subscriptions.)

ooo, is there a task for that I can just merge this into?

I'll take a quick look at just fixing this, I'm pretty sure it's legitimately one line (and if I'm wrong, there might be an unrelated bug at play here, which would be good to know about).

Closed by commit rP741477785640.