Page MenuHomePhabricator

Select all available bodies when rendering a feed story
ClosedPublic

Authored by epriestley on Nov 5 2013, 4:40 PM.
Tags
None
Referenced Files
F14063930: D7504.diff
Mon, Nov 18, 8:53 PM
F13973895: D7504.id16913.diff
Oct 18 2024, 3:11 AM
Unknown Object (File)
Oct 9 2024, 8:28 PM
Unknown Object (File)
Sep 21 2024, 2:18 AM
Unknown Object (File)
Sep 19 2024, 3:03 AM
Unknown Object (File)
Sep 19 2024, 3:02 AM
Unknown Object (File)
Sep 17 2024, 1:31 AM
Unknown Object (File)
Sep 15 2024, 5:51 AM
Subscribers
Tokens
"Doubloon" token, awarded by btrahan.

Details

Summary

Fixes T4060. The logic here is:

  • When you take several actions at once, we show a single feed story for all of them.
  • We choose the "most interesting" title for the feed story. For example, "close task" is more interesting than "add CC".

Currently, the issue with this is:

  • "Add comment" is the least interesting title. I think this is correct: all other actions are more interesting than the fact that you added a comment.
  • We try to conserve the number of objects we need to load by rendering only the most interesting transaction.

To fix this:

  • Stop being so conservative; load all of the transactions and all of their PHIDs.
  • Add bodies from any transactions which render bodies. In all cases (I think?) this is a maximum of one comment adding a body.

The end result is a story like this:

epriestley closed T123: the building is on fire.

"Okay guys I put the fire out"
Test Plan

See screenshot.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Add comment being higher than updated subscribers seems more correct though (but, yes, below everything else).

Maybe the rule should be something like this:

  • If you add only yourself as a subscriber only, the CC transaction has low strength (say, 0.25).
  • If you add anyone else or remove yourself, the CC transaction has normal strength (1.0).
  • "Comment" currently has strength 0.5.

...since adding CCs other than yourself seems very slightly more interesting than "commented"?

The "updated" text is also lazy, it should eventually show the full action ("epriestley added alincoln as a subscriber.").

Yeah, that seems like the "best" rendering for consistency and user-expectation, once the text shows names it could probably go either way :) (though just "Added Comment" for the trivial case still seems marginally better for UX).

Yeah, that makes sense to me. That wouldn't apply to Maniphest for now anyway since it still has funky custom subscription management, but I'll probably add that rule when I clean up the strings, probably after switching Maniphest over.