Page MenuHomePhabricator

show user avatar in feed for all or no feed entries.
Closed, InvalidPublic

Description

Currently the feed shows sometimes the avatar sometimes not if a user changes objects. Is there a rule for that? can the visibility of the avatar more consistent?

Event Timeline

hwinkel raised the priority of this task from to Needs Triage.
hwinkel updated the task description. (Show Details)
hwinkel added a project: Feed.
hwinkel added subscribers: hwinkel, tolbrino, hsychla.

Avatars are displayed for "major" stories, but not for "minor" stories.

OK, fine with that. Is there a definition whats major and minor? I see my comment here is a major thing. Wow ;-)

It's currently still quite inconsistent (while there are still apps transitioning to the transactions infrastructure) - in general, I believe that the breakdown is planned to be something like this:

Major:

  • Added a comment.
  • Created an object (task, diff, commit, project).

Minor:

  • Updated subscribers.
  • "Most" state changes on objects.

The big weird ones at the moment are that Create Task is a minor story, and adding a comment to a diff is missing a body (which makes it look strange), other than that it's pretty reasonable.

Your image is shown if you said something, it's not if you didn't. If there is a specific feed story type that does not do that, then go ahead and list and we can look at fixing, but I think this works correctly on anything with transactions.

btrahan claimed this task.

So I think @chad clarified how this works - if you say something there's a pic and if you don't there's no pic.

Definitely let us know if this is inconsistent for specific types of stories or what have you.