Page MenuHomePhabricator
Differential D9562

Make Pholio work a little better on mobile
ClosedPublic
Actions

Authored by epriestley on Jun 15 2014, 9:59 PM.
Tags
None
Referenced Files
F14032833: D9562.diff
Sat, Nov 9, 3:55 PM
F14022278: D9562.diff
Wed, Nov 6, 4:02 PM
F13991273: D9562.id22920.diff
Tue, Oct 22, 9:43 AM
F13991272: D9562.id22919.diff
Tue, Oct 22, 9:43 AM
F13966172: D9562.id22919.diff
Oct 16 2024, 6:46 AM
Unknown Object (File)
Sep 19 2024, 10:43 AM
Unknown Object (File)
Sep 12 2024, 9:35 AM
Unknown Object (File)
Sep 12 2024, 9:35 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T2644: Make Pholio work better on mobile
Commits
Restricted Diffusion Commit
rP4ea14ae37677: Make Pholio work a little better on mobile
Summary

Ref T2644. This adjusts thumb sizing so the "X" button is visible, and hides the uploader on devices for now.

The thumb stuff I'm sort of hacking (we'll cut off a little bit of wide thumbs on the iPhone), but it looks fine, is usable, and works a little better in landscape mode and at tablet sizes.

Test Plan

Screen_Shot_2014-06-15_at_2.56.13_PM.png (744×396 px, 220 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22919.Jun 15 2014, 9:59 PM
epriestley retitled this revision from to Make Pholio work a little better on mobile.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T2644: Make Pholio work better on mobile.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 15 2014, 9:59 PM
chad accepted this revision.Jun 15 2014, 9:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2014, 9:59 PM
Harbormaster completed remote builds in B1128: Diff 22919.Jun 15 2014, 10:00 PM
epriestley closed this revision.Jun 15 2014, 10:00 PM
epriestley updated this revision to Diff 22920.

Closed by commit rP4ea14ae37677 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
pholio/
controller/
2 lines
webroot/
rsrc/
css/
application/
pholio/
13 lines

Diff 22920

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/pholio/controller/PholioMockEditController.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio-edit.css

Loading...
Phabricator · Built by Phacility