Page MenuHomePhabricator

Make the meme cache case-sensitive
ClosedPublic

Authored by epriestley on Jul 26 2018, 4:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 14 2024, 9:05 PM
Unknown Object (File)
Feb 12 2024, 8:22 PM
Unknown Object (File)
Jan 25 2024, 11:38 AM
Unknown Object (File)
Jan 16 2024, 9:27 AM
Unknown Object (File)
Dec 22 2023, 12:05 AM
Unknown Object (File)
Dec 18 2023, 2:33 PM
Unknown Object (File)
Nov 30 2023, 2:23 AM
Unknown Object (File)
Nov 25 2023, 7:35 PM
Subscribers
None

Details

Summary

Fixes T13172. At one point we always capitalized all the text, and the cache uses capitalized text.

However, we stopped capitalizing the text at some point. Modern memes are more more subtle than old memes, and when we eventualy add support for things like "explodey brain" we'll certainly want to support mixed case.

Practically, this stops you from changing the capitalization of a cached meme. Get rid of the cache transform.

Test Plan

none lul

(I don't have gd installed locally and buiding it requires building libjpeg and libpng or giving up and using brew. I'l vet this in production.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 26 2018, 7:09 PM
This revision was automatically updated to reflect the committed changes.