Page MenuHomePhabricator

Always serve "{meme ...}" from the CDN domain, never from the primary domain
ClosedPublic

Authored by epriestley on Mar 8 2018, 3:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 12:40 PM
Unknown Object (File)
Wed, Feb 28, 12:46 AM
Unknown Object (File)
Jan 11 2024, 12:13 PM
Unknown Object (File)
Jan 6 2024, 8:34 AM
Unknown Object (File)
Jan 5 2024, 11:39 PM
Unknown Object (File)
Jan 5 2024, 1:37 PM
Unknown Object (File)
Dec 28 2023, 12:02 AM
Unknown Object (File)
Dec 23 2023, 2:45 AM
Subscribers
None

Details

Summary

Ref T13101. This is a minimal change to make "{meme ...}" work with the new Content-Security-Policy by using an Ajax request to generate the image and then swapping the source on the client.

This could be much cleaner (see T5258, etc).

Test Plan

Used {meme, src=cat6, above=i am, below=cat}, chuckled completely unironically.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 3:47 PM
This revision was automatically updated to reflect the committed changes.