Page MenuHomePhabricator

Always serve "{meme ...}" from the CDN domain, never from the primary domain
ClosedPublic

Authored by epriestley on Mar 8 2018, 3:40 PM.
Tags
None
Referenced Files
F18410815: D19196.id.diff
Sat, Aug 30, 5:21 AM
F18403557: D19196.diff
Fri, Aug 29, 9:21 PM
F18124883: D19196.id45976.diff
Wed, Aug 13, 12:46 PM
F18124880: D19196.id45975.diff
Wed, Aug 13, 12:46 PM
F18124875: D19196.id.diff
Wed, Aug 13, 12:46 PM
F18112178: D19196.diff
Tue, Aug 12, 4:07 PM
F18094964: D19196.id.diff
Thu, Aug 7, 10:27 PM
F17711938: D19196.diff
Jul 17 2025, 9:19 AM
Subscribers
None

Details

Summary

Ref T13101. This is a minimal change to make "{meme ...}" work with the new Content-Security-Policy by using an Ajax request to generate the image and then swapping the source on the client.

This could be much cleaner (see T5258, etc).

Test Plan

Used {meme, src=cat6, above=i am, below=cat}, chuckled completely unironically.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 3:47 PM
This revision was automatically updated to reflect the committed changes.