Remove incorrect policy language on Diff reviewers
ClosedPublic
Actions

Authored by chad on Aug 6 2017, 2:34 AM.

Tags

None

Referenced Files

	F14088166: D18349.id.diff
	Sun, Nov 24, 1:51 AM

	F14084290: D18349.diff
	Sat, Nov 23, 7:35 AM

	Unknown Object (File)
	Mon, Nov 18, 10:46 PM

	Unknown Object (File)
	Thu, Nov 14, 8:09 PM

	Unknown Object (File)
	Mon, Nov 11, 2:40 PM

	Unknown Object (File)
	Wed, Nov 6, 9:09 PM

	Unknown Object (File)
	Oct 24 2024, 5:18 PM

	Unknown Object (File)
	Oct 16 2024, 12:57 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12952: Reviewer not able to see diff

Commits

rP8ca29a607a2b: Remove incorrect policy language on Diff reviewers

Summary

Fixes T12952. This never work AFAIK, so resolves this mis-information. See T4411 for follow up.

Test Plan

Click on policy for a diff, no longer see text.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Aug 6 2017, 2:34 AM

Harbormaster completed remote builds in B17922: Diff 44103.Aug 6 2017, 2:34 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 6 2017, 2:34 AM

Harbormaster completed remote builds in B17922: Diff 44103.Aug 6 2017, 2:35 AM

epriestley accepted this revision.Aug 6 2017, 11:44 AM

This revision is now accepted and ready to land.Aug 6 2017, 11:44 AM

Closed by commit rP8ca29a607a2b: Remove incorrect policy language on Diff reviewers (authored by chad, committed by chad). · Explain WhyAug 6 2017, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialRevision.php

1 line

Diff 44109

View Options

src/applications/differential/storage/DifferentialRevision.php

Remove incorrect policy language on Diff reviewersClosedPublicActions