Page MenuHomePhabricator

Validate menu item fields (links, projects, dashboards, applications, forms, etc)
ClosedPublic

Authored by epriestley on Jan 20 2017, 7:16 PM.
Tags
None
Referenced Files
F18741265: D17235.id.diff
Thu, Oct 2, 10:13 AM
F18737063: D17235.diff
Wed, Oct 1, 8:49 AM
F18630442: D17235.id41452.diff
Sep 16 2025, 11:40 AM
F18630404: D17235.id41452.diff
Sep 16 2025, 11:35 AM
F18630398: D17235.id41452.diff
Sep 16 2025, 11:34 AM
F18609592: D17235.diff
Sep 14 2025, 3:30 AM
F18566065: D17235.id.diff
Sep 9 2025, 2:17 PM
F18544324: D17235.diff
Sep 8 2025, 12:33 AM
Subscribers
None

Details

Summary

Ref T12128. This adds validation to menu items.

This feels a touch flimsy-ish (kind of copy/paste heavy?) but maybe it can be cleaned up a bit once some similar lightweight modular item types (build steps in Harbormaster, blueprints in Drydock) convert.

Test Plan
  • Tried to create each item with errors (no dashboard, no project, etc). Got appropriate form errors.
  • Created valid items of each type.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable