Page MenuHomePhabricator

Validate menu item fields (links, projects, dashboards, applications, forms, etc)
ClosedPublic

Authored by epriestley on Jan 20 2017, 7:16 PM.
Tags
None
Referenced Files
F15441617: D17235.id41452.diff
Wed, Mar 26, 6:53 PM
F15441616: D17235.id41450.diff
Wed, Mar 26, 6:53 PM
F15441615: D17235.id.diff
Wed, Mar 26, 6:53 PM
F15439326: D17235.diff
Wed, Mar 26, 7:00 AM
F15438161: D17235.diff
Tue, Mar 25, 11:37 PM
F15424526: D17235.diff
Sat, Mar 22, 10:53 PM
F15424483: D17235.id41452.diff
Sat, Mar 22, 10:38 PM
F15386370: D17235.id41452.diff
Sat, Mar 15, 12:26 AM
Subscribers
None

Details

Summary

Ref T12128. This adds validation to menu items.

This feels a touch flimsy-ish (kind of copy/paste heavy?) but maybe it can be cleaned up a bit once some similar lightweight modular item types (build steps in Harbormaster, blueprints in Drydock) convert.

Test Plan
  • Tried to create each item with errors (no dashboard, no project, etc). Got appropriate form errors.
  • Created valid items of each type.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable