Page MenuHomePhabricator

Validate menu item fields (links, projects, dashboards, applications, forms, etc)
ClosedPublic

Authored by epriestley on Jan 20 2017, 7:16 PM.
Tags
None
Referenced Files
F18288704: D17235.diff
Sat, Aug 23, 8:32 AM
F18179724: D17235.id41452.diff
Sat, Aug 16, 4:07 AM
F18093022: D17235.id41452.diff
Thu, Aug 7, 2:50 PM
F18093021: D17235.id41450.diff
Thu, Aug 7, 2:50 PM
F18093020: D17235.id.diff
Thu, Aug 7, 2:50 PM
F18090613: D17235.diff
Wed, Aug 6, 4:23 PM
F18089405: D17235.id41450.diff
Wed, Aug 6, 11:24 AM
F18052286: D17235.id.diff
Mon, Aug 4, 2:03 AM
Subscribers
None

Details

Summary

Ref T12128. This adds validation to menu items.

This feels a touch flimsy-ish (kind of copy/paste heavy?) but maybe it can be cleaned up a bit once some similar lightweight modular item types (build steps in Harbormaster, blueprints in Drydock) convert.

Test Plan
  • Tried to create each item with errors (no dashboard, no project, etc). Got appropriate form errors.
  • Created valid items of each type.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable