Page MenuHomePhabricator

Make yellow "draft" bubbles more generic
ClosedPublic

Authored by epriestley on Jan 13 2017, 3:37 PM.
Tags
None
Referenced Files
F15451753: D17205.id41368.diff
Fri, Mar 28, 11:38 PM
F15449627: D17205.id.diff
Fri, Mar 28, 11:20 AM
F15438821: D17205.diff
Wed, Mar 26, 3:50 AM
Unknown Object (File)
Feb 21 2025, 3:04 PM
Unknown Object (File)
Feb 11 2025, 9:13 PM
Unknown Object (File)
Jan 30 2025, 6:00 AM
Unknown Object (File)
Jan 30 2025, 1:26 AM
Unknown Object (File)
Jan 27 2025, 11:01 AM
Subscribers
None

Details

Summary

Fixes T12095. Ref T6660. The old code for this was specific to Differential, using the DifferentialDraft table.

Instead, make the EditEngine / VersionedDraft code create and remove a <objectPHID, authorPHID> edge when a particular author creates drafts.

Some applications have drafts beyond VersionedDrafts, notably inline comments. Before writing "yes, draft" or "no, no draft", ask the object if it has any custom draft stuff we need to know about.

This should fix all the yellow bubble bugs I created in T11114 and allow us to bring the feature to Audit fairly easily.

Test Plan

Created and deleted comments and inlines, reloading the list view after each change. Couldn't find a way to break the list view anymore.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 13 2017, 4:50 PM
This revision was automatically updated to reflect the committed changes.