Page MenuHomePhabricator

Update diff highlight colors for better color blindess distinction
ClosedPublic

Authored by chad on Jan 4 2017, 7:22 PM.
Tags
None
Referenced Files
F13997914: D17138.diff
Thu, Oct 24, 6:46 AM
F13997146: D17138.id.diff
Thu, Oct 24, 2:36 AM
F13995901: D17138.id41214.diff
Wed, Oct 23, 4:31 PM
F13965726: D17138.diff
Oct 16 2024, 3:56 AM
Unknown Object (File)
Sep 1 2024, 7:42 PM
Unknown Object (File)
Aug 10 2024, 12:54 AM
Unknown Object (File)
Aug 10 2024, 12:53 AM
Unknown Object (File)
Aug 10 2024, 12:53 AM
Subscribers

Details

Summary

Tweaks the diff colors here a bit, as well as making full diffs slightly easier to read in full. Ref T12060

Test Plan

Tested prose diffs, email prose diffs, and a regular Differential revision.

pasted_file (1×2 px, 371 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 4 2017, 7:23 PM
This revision was automatically updated to reflect the committed changes.

I can barely see the light green shade now, but maybe just a monitor issue unique to me. Light red is OK.

Well, maybe "barely see" is a little dramatic. But it's light enough that scanning the right-hand-side of two-up diffs for new blocks of code feels harder than it used to be.

I changed new-full to be light instead of bright, maybe that's it?

(it felt too overpowering with a richer green)

I can bring light green up a hair