Page MenuHomePhabricator

Update diff highlight colors for better color blindess distinction
ClosedPublic

Authored by chad on Jan 4 2017, 7:22 PM.
Tags
None
Referenced Files
F15495442: D17138.id41215.diff
Sun, Apr 13, 4:19 AM
F15475713: D17138.id.diff
Sun, Apr 6, 10:23 PM
F15473369: D17138.diff
Sat, Apr 5, 9:23 PM
F15435339: D17138.diff
Tue, Mar 25, 7:51 AM
F15418665: D17138.id41215.diff
Fri, Mar 21, 12:42 AM
F15385916: D17138.id.diff
Mar 14 2025, 11:39 PM
F15379202: D17138.diff
Mar 13 2025, 7:18 PM
F15285667: D17138.diff
Mar 4 2025, 3:14 PM
Subscribers

Details

Summary

Tweaks the diff colors here a bit, as well as making full diffs slightly easier to read in full. Ref T12060

Test Plan

Tested prose diffs, email prose diffs, and a regular Differential revision.

pasted_file (1×2 px, 371 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 4 2017, 7:23 PM
This revision was automatically updated to reflect the committed changes.

I can barely see the light green shade now, but maybe just a monitor issue unique to me. Light red is OK.

Well, maybe "barely see" is a little dramatic. But it's light enough that scanning the right-hand-side of two-up diffs for new blocks of code feels harder than it used to be.

I changed new-full to be light instead of bright, maybe that's it?

(it felt too overpowering with a richer green)

I can bring light green up a hair