Page MenuHomePhabricator

Update diff highlight colors for better color blindess distinction
ClosedPublic

Authored by chad on Jan 4 2017, 7:22 PM.

Details

Summary

Tweaks the diff colors here a bit, as well as making full diffs slightly easier to read in full. Ref T12060

Test Plan

Tested prose diffs, email prose diffs, and a regular Differential revision.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Jan 4 2017, 7:23 PM
This revision was automatically updated to reflect the committed changes.

I can barely see the light green shade now, but maybe just a monitor issue unique to me. Light red is OK.

Well, maybe "barely see" is a little dramatic. But it's light enough that scanning the right-hand-side of two-up diffs for new blocks of code feels harder than it used to be.

I changed new-full to be light instead of bright, maybe that's it?

(it felt too overpowering with a richer green)

I can bring light green up a hair