Differential D17171

Re-darken full width diff colors
ClosedPublic
Actions

Authored by chad on Jan 10 2017, 9:14 PM.

Tags

None

Referenced Files

	F15416137: D17171.diff
	Thu, Mar 20, 9:30 AM

	F15385993: D17171.id.diff
	Fri, Mar 14, 11:49 PM

	F15382182: D17171.id41297.diff
	Fri, Mar 14, 11:09 AM

	Unknown Object (File)
	Sun, Feb 23, 4:58 PM

	Unknown Object (File)
	Sat, Feb 22, 3:24 PM

	Unknown Object (File)
	Fri, Feb 21, 3:02 PM

	Unknown Object (File)
	Fri, Feb 21, 1:58 PM

	Unknown Object (File)
	Fri, Feb 21, 12:19 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T12089: New red/green highlight colors are incorrect for added or removed new lines

Commits

rP63af2275ca05: Re-darken full width diff colors

Summary

Ref T12089. This reverts back to using "bright" colors for full width changes in green and red.

Test Plan

Review diffs, see full width colors.

pasted_file (1×3 px, 995 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Jan 10 2017, 9:14 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 10 2017, 9:14 PM

chad edited the test plan for this revision. (Show Details)Jan 10 2017, 9:15 PM

Harbormaster completed remote builds in B15184: Diff 41297.Jan 10 2017, 9:15 PM

This revision is now accepted and ready to land.Jan 10 2017, 9:20 PM

this green has more contrast than the previous "bright" green, just FYI, which is why I made this change.

Closed by commit rP63af2275ca05: Re-darken full width diff colors (authored by chad, committed by chad). · Explain WhyJan 10 2017, 9:25 PM

This revision was automatically updated to reflect the committed changes.

If this color scheme isn't good for red-green colorblind users we can introduce a setting, but this was definitely noticeably worse for me too (I just couldn't put my finger on why).

epriestley mentioned this in T12089: New red/green highlight colors are incorrect for added or removed new lines.Jan 10 2017, 9:48 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

12 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

10 lines

Diff 41298

resources/celerity/map.php

Loading...

webroot/rsrc/css/application/differential/changeset-view.css

Loading...