Page MenuHomePhabricator

Re-darken full width diff colors
ClosedPublic

Authored by chad on Jan 10 2017, 9:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 29, 2:20 PM
Unknown Object (File)
Sun, Jun 15, 8:39 PM
Unknown Object (File)
Sun, Jun 15, 8:25 PM
Unknown Object (File)
Sat, Jun 14, 1:41 AM
Unknown Object (File)
May 29 2025, 8:57 AM
Unknown Object (File)
May 8 2025, 5:16 AM
Unknown Object (File)
Apr 27 2025, 6:35 AM
Unknown Object (File)
Apr 25 2025, 8:15 AM
Subscribers

Details

Summary

Ref T12089. This reverts back to using "bright" colors for full width changes in green and red.

Test Plan

Review diffs, see full width colors.

pasted_file (1×3 px, 995 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 10 2017, 9:20 PM

this green has more contrast than the previous "bright" green, just FYI, which is why I made this change.

This revision was automatically updated to reflect the committed changes.

If this color scheme isn't good for red-green colorblind users we can introduce a setting, but this was definitely noticeably worse for me too (I just couldn't put my finger on why).