Page MenuHomePhabricator
Differential D17013

Fix an issue where tokenizers can sort milestone results into the wrong query phase
ClosedPublic
Actions

Authored by epriestley on Dec 9 2016, 2:11 PM.
Tags
None
Referenced Files
F14838898: D17013.id40936.diff
Fri, Jan 31, 7:04 PM
Unknown Object (File)
Tue, Jan 28, 2:09 AM
Unknown Object (File)
Fri, Jan 24, 6:24 PM
Unknown Object (File)
Fri, Jan 24, 6:24 PM
Unknown Object (File)
Fri, Jan 24, 6:24 PM
Unknown Object (File)
Fri, Jan 24, 6:24 PM
Unknown Object (File)
Thu, Jan 23, 3:36 AM
Unknown Object (File)
Tue, Jan 21, 8:15 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11955: Tag autocomplete doesn't always include milestones
Commits
rP9c38b61e51a0: Fix an issue where tokenizers can sort milestone results into the wrong query…
Summary

Fixes T11955. Currently, milestones have an internal name of "Parent (Milestone) ...".

This makes them look like they're prefix matches for "Parent", but they're actually prefix matches for "Milestone".

Reorder the names so that the internal name is "Milestone Parent ...".

Test Plan

Created a project "AAA" with milestone "BBB". Searched for "AAA", found "AAA" and milestone "AAA (BBB)".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40932.Dec 9 2016, 2:11 PM
epriestley retitled this revision from to Fix an issue where tokenizers can sort milestone results into the wrong query phase.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11955: Tag autocomplete doesn't always include milestones.
epriestley mentioned this in T11955: Tag autocomplete doesn't always include milestones.Dec 9 2016, 2:12 PM
chad accepted this revision.Dec 9 2016, 4:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 9 2016, 4:03 PM
Closed by commit rP9c38b61e51a0: Fix an issue where tokenizers can sort milestone results into the wrong query… (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2016, 4:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
typeahead/
13 lines

Diff 40936

View Options

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...
Phabricator · Built by Phacility