Give Phragment a sort of tetris block thing as a title glyph
ClosedPublic
Actions

Authored by epriestley on Sep 22 2016, 10:08 PM.

Details

Reviewers

avivey
chad

Maniphest Tasks

T11679: Phragment has invalid (non-UTF8) title glyph

Commits

rPa799d0a89332: Give Phragment a sort of tetris block thing as a title glyph

Summary

Fixes T11679. This application is probably vanishing into the aether eventually, but stop it from fataling for now.

Here's the glyph: ▛

It's like a fragment of a block of file data! Right? Obviously.

Test Plan

Visited /phragment/ with glpyhs on, saw the glyph.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39930.Sep 22 2016, 10:08 PM

epriestley retitled this revision from to Give Phragment a sort of tetris block thing as a title glyph.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11679: Phragment has invalid (non-UTF8) title glyph.

Herald added a subscriber: hach-que. · View Herald TranscriptSep 22 2016, 10:08 PM

This looks hi-pri, must fix asap.

This revision is now accepted and ready to land.Sep 22 2016, 10:12 PM

Closed by commit rPa799d0a89332: Give Phragment a sort of tetris block thing as a title glyph (authored by epriestley, committed by epriestley). · Explain WhySep 22 2016, 10:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phragment/

application/

PhabricatorPhragmentApplication.php

2 lines

Diff 39931

View Options

src/applications/phragment/application/PhabricatorPhragmentApplication.php

Give Phragment a sort of tetris block thing as a title glyphClosedPublicActions