Page MenuHomePhabricator

Add a lint error about use of PHP short array syntax ('[...]')
ClosedPublic

Authored by epriestley on Aug 1 2016, 11:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 27, 12:04 PM
Unknown Object (File)
Sat, Jun 25, 12:43 PM
Unknown Object (File)
Thu, Jun 16, 11:35 AM
Unknown Object (File)
Feb 25 2017, 7:50 PM
Unknown Object (File)
Feb 25 2017, 7:50 PM
Unknown Object (File)
Feb 25 2017, 7:50 PM
Unknown Object (File)
Feb 10 2017, 5:12 AM
Unknown Object (File)
Jan 30 2017, 4:16 PM
Subscribers
None

Details

Summary

Ref T11409. Add lint to detect using [...] to define arrays. This doesn't work in PHP 5.2/5.3, which some of our users run.

Test Plan
  • Ran arc unit.
  • Ran arc lint src/applications/harbormaster/conduit/HarbormasterQueryBuildsConduitAPIMethod.php to detect the issue in T11409.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a lint error about use of PHP short array syntax ('[...]').
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, yelirekim.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2016, 2:22 PM
This revision was automatically updated to reflect the committed changes.