Page MenuHomePhabricator

Add a lint error about use of PHP short array syntax ('[...]')
ClosedPublic

Authored by epriestley on Aug 1 2016, 11:26 AM.
Tags
None
Referenced Files
F17752766: D16357.diff
Tue, Jul 22, 7:41 AM
F17626863: D16357.id39341.diff
Thu, Jul 10, 5:21 AM
Unknown Object (File)
Jun 27 2025, 11:28 AM
Unknown Object (File)
Jun 27 2025, 5:43 AM
Unknown Object (File)
Jun 2 2025, 1:52 AM
Unknown Object (File)
Jun 1 2025, 6:35 PM
Unknown Object (File)
May 30 2025, 5:35 AM
Unknown Object (File)
May 29 2025, 5:58 AM
Subscribers
None

Details

Summary

Ref T11409. Add lint to detect using [...] to define arrays. This doesn't work in PHP 5.2/5.3, which some of our users run.

Test Plan
  • Ran arc unit.
  • Ran arc lint src/applications/harbormaster/conduit/HarbormasterQueryBuildsConduitAPIMethod.php to detect the issue in T11409.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a lint error about use of PHP short array syntax ('[...]').
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, yelirekim.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2016, 2:22 PM
This revision was automatically updated to reflect the committed changes.