Page MenuHomePhabricator
Differential D16358

Use long array syntax for compatibility instead of short array syntax
ClosedPublic
Actions

Authored by epriestley on Aug 1 2016, 12:08 PM.
Tags
None
Referenced Files
F19076081: D16358.id39342.diff
Dec 1 2025, 11:34 AM
F19075208: D16358.diff
Dec 1 2025, 9:00 AM
F19062253: D16358.id.diff
Nov 29 2025, 3:21 PM
F19013120: D16358.diff
Nov 22 2025, 3:04 PM
F18876405: D16358.id39342.diff
Nov 6 2025, 12:16 AM
F18872914: D16358.id.diff
Nov 5 2025, 6:53 AM
F18870891: D16358.diff
Nov 4 2025, 7:37 PM
F18835246: D16358.id39342.diff
Oct 26 2025, 2:29 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
yelirekim
chad
Maniphest Tasks
T11409: harbormaster.buildquery fatals on short array syntax in older PHP
Commits
rP5380d877921e: Use long array syntax for compatibility instead of short array syntax
Summary

Fixes T11409. This syntax isn't compatible with older PHP.

Test Plan

Ran arc lint on the file.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39340.Aug 1 2016, 12:08 PM
epriestley retitled this revision from to Use long array syntax for compatibility instead of short array syntax.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, yelirekim.
epriestley added a task: T11409: harbormaster.buildquery fatals on short array syntax in older PHP.
Owners added a subscriber: Restricted Owners Package.Aug 1 2016, 12:08 PM
chad accepted this revision.Aug 1 2016, 2:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2016, 2:23 PM
Closed by commit rP5380d877921e: Use long array syntax for compatibility instead of short array syntax (authored by epriestley, committed by epriestley). · Explain WhyAug 1 2016, 5:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
conduit/
9 lines

Diff 39342

View Options

src/applications/harbormaster/conduit/HarbormasterQueryBuildsConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility