Page MenuHomePhabricator
Differential D16168

Add space under comment previews
ClosedPublic
Actions

Authored by chad on Jun 22 2016, 7:15 PM.
Tags
None
Referenced Files
F14055249: D16168.diff
Sat, Nov 16, 9:50 AM
F14042192: D16168.diff
Tue, Nov 12, 1:17 AM
F14026114: D16168.diff
Thu, Nov 7, 11:43 PM
F13996577: D16168.diff
Wed, Oct 23, 10:13 PM
F13984749: D16168.id.diff
Sun, Oct 20, 3:39 PM
Unknown Object (File)
Oct 9 2024, 4:14 AM
Unknown Object (File)
Sep 25 2024, 4:22 AM
Unknown Object (File)
Sep 11 2024, 7:18 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T11166: When an install has no footer, Maniphest task previews have no bottom margin
Commits
rP3bb3170a2c7c: Add space under comment previews
Summary

Fixes T11166. Adds some class, and space to the preview widget.

Test Plan

Test Maniphest, Ponder, etc, without a footer.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 38893.Jun 22 2016, 7:15 PM
chad retitled this revision from to Add space under comment previews.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T11166: When an install has no footer, Maniphest task previews have no bottom margin.
Herald added a subscriber: Korvin. · View Herald TranscriptJun 22 2016, 7:15 PM
epriestley accepted this revision.Jun 22 2016, 7:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2016, 7:15 PM
Closed by commit rP3bb3170a2c7c: Add space under comment previews (authored by chad, committed by chad). · Explain WhyJun 22 2016, 7:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
transactions/
view/
1 line
webroot/
rsrc/
css/
phui/
4 lines

Diff 38894

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility