Strip tips out of commit messages from `arc backout`
ClosedPublic
Actions

Authored by epriestley on Apr 2 2016, 1:29 PM.

Details

Reviewers

chad

Maniphest Tasks

T10707: arc backout added bonus free "tips" to end of commit message

Commits

rARC68f4a77d42c5: (stable) Promote 2016 Week 15
rARC8701e6c1f31a: Strip tips out of commit messages from `arc backout`

Summary

Fixes T10707. Currently, arc backout creates a commit message which includes questionably-helpful "tips" in the message itself.

Strip these out.

Test Plan

Used arc backout to revert any commit, then git show to see the generated message.

Before patch: included tips.
After patch: no tips.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37541.Apr 2 2016, 1:29 PM

epriestley retitled this revision from to Strip tips out of commit messages from `arc backout`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10707: arc backout added bonus free "tips" to end of commit message.

epriestley mentioned this in T10707: arc backout added bonus free "tips" to end of commit message.Apr 2 2016, 1:31 PM

chad accepted this revision.Apr 2 2016, 2:20 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 2 2016, 2:20 PM

Closed by commit rARC8701e6c1f31a: Strip tips out of commit messages from `arc backout` (authored by epriestley, committed by epriestley). · Explain WhyApr 2 2016, 2:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBackoutWorkflow.php

3 lines

Diff 37543

View Options

src/workflow/ArcanistBackoutWorkflow.php

Strip tips out of commit messages from `arc backout`ClosedPublicActions