Page MenuHomePhabricator

Declare tokenCache on AASTNode
ClosedPublic

Authored by epriestley on Feb 27 2016, 3:25 PM.
Tags
None
Referenced Files
F13975521: D15358.diff
Fri, Oct 18, 10:30 AM
F13971322: D15358.diff
Thu, Oct 17, 12:49 PM
F13967733: D15358.id37035.diff
Wed, Oct 16, 3:33 PM
F13963976: D15358.diff
Tue, Oct 15, 7:03 PM
Unknown Object (File)
Sat, Oct 12, 1:05 AM
Unknown Object (File)
Oct 4 2024, 1:26 PM
Unknown Object (File)
Sep 30 2024, 6:57 PM
Unknown Object (File)
Sep 30 2024, 1:48 PM
Subscribers
None

Details

Summary

See discussion in T10462. Because this class extends Phobject, calling $this->undeclaredProperty = $value; throws.

Declare $tokenCache.

Test Plan

Added debugging statements, saw change cause cache hits to occur.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Declare tokenCache on AASTNode.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 27 2016, 3:29 PM
This revision was automatically updated to reflect the committed changes.